/curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip custom Connection: headers when doing HTTP/2 #401

Closed
bagder opened this Issue Aug 27, 2015 · 0 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
1 participant
@bagder
@bagder
Member

bagder commented Aug 27, 2015

An application may opt to use custom Connection: headers with libcurl, but if the server supports HTTP/2 those headers are not allowed.

RFC 7540 section 8.1.2.2 states: "An endpoint MUST NOT generate an HTTP/2 message containing connection-specific header fields; any message containing connection-specific header fields MUST be treated as malformed"

So, to let applications keep working with HTTP/1.1 or HTTP/2, libcurl must filter out the Connection: headers for h2.

@bagder bagder added the HTTP/2 label Aug 27, 2015

@bagder bagder closed this in 1869164 Sep 3, 2015

jgsogo added a commit to jgsogo/curl that referenced this issue Oct 19, 2015

@bagder @jgsogo
http2: don't pass on Connection: headers 
RFC 7540 section 8.1.2.2 states: "An endpoint MUST NOT generate an
HTTP/2 message containing connection-specific header fields; any message
containing connection-specific header fields MUST be treated as
malformed"

Closes curl#401
3baf321

@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.