-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi/socket: assertion failure when requesting h2 in parallel #4012
Comments
Potentially related to #3991 (same assertion gets failed) but submitting as separate issue because the way to reproduce is very different. |
Hm, I'm now also able to reproduce the bug by doing just a single request in parallel... very skeptical about this bug 😕 |
Thanks, with your example code I too hit the assert. I'm on it. |
Whew, I thought I was going crazy (spent an hour double-checking, seemed too simple). Thanks! |
- The transfer hashes weren't using the correct keys so removing entries failed. - Simplified the iteration logic over transfers sharing the same socket and they now simply are set to expire and thus get handled in the "regular" timer loop instead. Fixes #4012 (ideally)
Oh man what a brain malfunction. Stand by for PR. |
Probably doesn't solve #3991 I just got a busy loop after I ran the test repeatedly.
|
I could spot the |
I think I'll proceed and land #4014 first and then we can continue and see if we can reproduce further problems and take them on, one by one. As usual. |
Decided to give curl master a try to see if there were any major issues left after my recent issue reports. Found a new segfault though...
https://gist.github.com/TvdW/1a64e73c77ce5b695515c4493675ccbe
The text was updated successfully, but these errors were encountered: