Skip to content

/curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build-breaking typo in release 7.65.1. #4102

Closed
AceCrow opened this issue Jul 9, 2019 · 3 comments

Comments

@AceCrow
Copy link

@AceCrow AceCrow commented Jul 9, 2019

I did this

  1. I downloaded the latest release from https://curl.haxx.se/download.html.
  2. (I created a dummy file GIT-INFO, because it needs to exist for 3).
  3. I ran buildconf.bat without any errors from cmd.
  4. I cd winbuild.
  5. I ran nmake /f Makefile.vc mode=dll.
  6. The compilation failed because the file src/tool_hugehelp.c included tool_hugehelp.hd.
  7. I changed tool_hugehelp.hd to tool_hugehelp.h and recompiled. This time succesfully.
  8. I tried to look upsrc\tool_hugehelp.c on github, but the file does not seem to exist there.

curl/libcurl version

curl 7.65.1 (x86_64-pc-win32) libcurl/7.65.1 Schannel WinIDN
Release-Date: 2019-06-05
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: AsynchDNS IDN IPv6 Kerberos Largefile NTLM SPNEGO SSL SSPI UnixSockets

operating system

Windows 10
@danielgustafsson

This comment has been minimized.

Sign in to view
Copy link
Member

@danielgustafsson danielgustafsson commented Jul 9, 2019

Fixed, thanks!
danielgustafsson added a commit that referenced this issue Jul 9, 2019
@danielgustafsson
buildconf: fix header filename
Loading status checks…
8dc21db 
The header file inclusion had a typo, it should be .h and not .hd.
Fix by renaming.

Fixes #4102
Reported-by: AceCrow on Github
@AceCrow

This comment has been minimized.

Sign in to view
Copy link
Author

@AceCrow AceCrow commented Jul 9, 2019

Np. Quick question. Why does GIT-INFO need to exist btw? The build seems to work fine with just a dummy file.
@danielgustafsson

This comment has been minimized.

Sign in to view
Copy link
Member

@danielgustafsson danielgustafsson commented Jul 9, 2019

GIT-INFO signals that the tree comes from a git repository and not a release tarball, and so the configure script needs to be built as it's not included.
caraitto added a commit to caraitto/curl that referenced this issue Jul 23, 2019
@danielgustafsson @caraitto
buildconf: fix header filename
2af3fb9 
The header file inclusion had a typo, it should be .h and not .hd.
Fix by renaming.

Fixes curl#4102
Reported-by: AceCrow on Github
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AceCrow @danielgustafsson
You can’t perform that action at this time.