Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build of cURL 7.65.3 fails on Red Hat 6 #4176

Closed
lanceeware opened this issue Jul 31, 2019 · 1 comment

Comments

@lanceeware
Copy link

commented Jul 31, 2019

Attempting build of cURL 7.65.3 on Red Hat Enterprise Linux 6 machine fails with following messages:

...
CC curl-tool_helpers.o
CC curl-tool_homedir.o
HUGE tool_hugehelp.c
CC curl-tool_hugehelp.o
tool_hugehelp.c:8330:6: error: redefinition of ‘hugehelp’
void hugehelp(void)
^
tool_hugehelp.c:8:6: note: previous definition of ‘hugehelp’ was here
void hugehelp(void)
^
make[3]: *** [curl-tool_hugehelp.o] Error 1
make[3]: Leaving directory '/home/builder/lware/RDVAS-2027/curl_new/src-static/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory '/home/builder/lware/RDVAS-2027/curl_new/src-static/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/builder/lware/RDVAS-2027/curl_new/src-static'
make: *** [libcurl] Error 2

After some investigation I found that this line in src/Makefile.in is the culprit:

@HAVE_LIBZ_FALSE@@USE_MANUAL_TRUE@ $(HUGECMD)(echo '#include "tool_setup.h"' > $(HUGE): \

The colon near the end of the line causes it to create a file named "tool_hugehelp.c:", which is not what is intended. Changing the colon character to a semicolon fixes the problem:

@HAVE_LIBZ_FALSE@@USE_MANUAL_TRUE@ $(HUGECMD)(echo '#include "tool_setup.h"' > $(HUGE); \

@bagder bagder added the build label Jul 31, 2019

@bagder

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

Ack, seems accurate. And you trigger this because you build without libz present, which clearly is pretty unusual since this regression was done in 5cf5d57 (7.64.1) on March 14 2019...

I'll push a pull request for this in a minute.

bagder added a commit that referenced this issue Jul 31, 2019

src/makefile: fix uncompressed hugehelp.c generation
Regression from 5cf5d57 (7.64.1)

Fixed-by: Lance Ware
Fixes #4176

@bagder bagder closed this in cf5aa92 Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.