Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
FTP: using TLS on data channel blocks connection reuse #4329
when setting CURLOPT_USE_SSL to CURLUSESSL_ALL, recent libcurl builds have become extremely slow. After debugging it became clear why:
Even when reusing the same easy handle, the control connection is closed after every FTP data download, instead of being kept open.
Looking at Wireshark the logs are filled with lots of "AUTH SSL", when there should in fact be only a single one.
Expected: only 1 "AUTH SSL"
The problem is caused by the following commit:
The changes in the commit issue a
Solution: Maybe skip the changes of the above commit in the FTP case?
For the FTP case it should only be a concern if the "close notify" message is received on the primary control connection, not on the data connection - which I suspect is what happens for you.
Can you verify that when this happens wrongly for you, is the