Skip to content

Test 1560 fails with --disable-ipv6 #4556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcelRaad opened this issue Nov 3, 2019 · 0 comments
Closed

Test 1560 fails with --disable-ipv6 #4556

MarcelRaad opened this issue Nov 3, 2019 · 0 comments
Labels
tests URL

Comments

@MarcelRaad
Copy link
Member

I did this

./buildconf
./configure --enable-debug --with-winssl --enable-alt-svc --disable-ipv6
make
cd tests
make
./runtests.pl 1560

The test failed because without ENABLE_IPV6, urlapi.c:hostname_check returns CURLUE_OK for http://[ab.be:1]/x, while the test expects it to return CURLUE_MALFORMED_INPUT.

I expected the following

The test to succeed.

curl/libcurl version

2839cfd

curl 7.67.0-DEV (i686-pc-mingw32) libcurl/7.67.0-DEV Schannel zlib/1.2.11
Release-Date: [unreleased]
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp smtp smtps telnet tftp
Features: alt-svc AsynchDNS Debug Kerberos Largefile libz NTLM SPNEGO SSL SSPI TrackMemory

operating system

Classic MinGW with MSYS 1.0 on Windows 10.
bagder added a commit that referenced this issue Nov 8, 2019
@bagder
test1560: require IPv6 for IPv6 aware URL parsing
a871e23 
The URL parser function can't reject a bad IPv6 address properly when
curl was built without IPv6 support.

Reported-by: Marcel Raad
Fixes #4556
@bagder bagder mentioned this issue Nov 8, 2019
Closed
@bagder bagder closed this as completed in 5d5bd44 Nov 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
tests URL
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test1560: require IPv6 for IPv6 aware URL parsing curl/curl
1 participant
@MarcelRaad