Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with `CURL_DISABLE_DOH` defined. #4565

Closed
wyattoday opened this issue Nov 6, 2019 · 0 comments
Labels

Comments

@wyattoday
Copy link
Contributor

@wyattoday wyattoday commented Nov 6, 2019

I did this

Defined CURL_DISABLE_DOH, built libCurl as usual. Build failed with:

\lib\url.c(406): error C2039: 'doh': is not a member of 'SingleRequest'
\lib\urldata.h(560): note: see declaration of 'SingleRequest'
\lib\url.c(406): error C2198: 'Curl_cfree': too few arguments for call
\lib\url.c(407): error C2039: 'doh': is not a member of 'SingleRequest'
\lib\urldata.h(560): note: see declaration of 'SingleRequest'
\lib\url.c(407): error C2198: 'Curl_cfree': too few arguments for call
\lib\url.c(408): error C2039: 'doh': is not a member of 'SingleRequest'
\lib\urldata.h(560): note: see declaration of 'SingleRequest'
\lib\url.c(408): error C2198: 'curl_slist_free_all': too few arguments for call
\lib\url.c(1990): error C2039: 'doh': is not a member of 'SingleRequest'
\lib\urldata.h(560): note: see declaration of 'SingleRequest'
\lib\url.c(1990): error C2198: 'Curl_close': too few arguments for call
\lib\url.c(1991): error C2039: 'doh': is not a member of 'SingleRequest'
\lib\urldata.h(560): note: see declaration of 'SingleRequest'
\lib\url.c(1991): error C2198: 'Curl_close': too few arguments for call

I expected the following

Successful builds.

curl/libcurl version

7.67.0

operating system

Windows 10 (but we make the same defines on unix variants, so it will fail there as well).

Solution?

I'll make a pull request in a second, but it's simple #ifndef CURL_DISABLE_DOH

wyattoday added a commit to wyattoday/curl that referenced this issue Nov 6, 2019
Fixes issue curl#4565: build fails with CURL_DISABLE_DOH.
@jay jay closed this in 93738ef Nov 7, 2019
@jay jay added the build label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.