Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl tool parallel transfer memory leaks #4772

Closed
geeknik opened this issue Dec 31, 2019 · 2 comments
Closed

curl tool parallel transfer memory leaks #4772

geeknik opened this issue Dec 31, 2019 · 2 comments
Labels
cmdline tool memory-leak

Comments

@geeknik
Copy link

geeknik commented Dec 31, 2019

I did this

Compiled curl with clang + ASAN.

$ ./curl -q -K test0075.conf file:///dev/null
Warning: test0075.conf:1: warning:
Warning: '000000000000000000000000000000000000000000000000000000000000000000000
Warning: 0000000000000000000000000000000000000000000000000000000000000000000000
***SNIP***
Warning: test0075.conf:20: warning: ' is unknown
***SNIP***
curl: (3) bad range in URL position 12:
jhhhhhhhhh[hh2▒
           ^

=================================================================
==8894==ERROR: LeakSanitizer: detected memory leaks

Indirect leak of 32480 byte(s) in 3 object(s) allocated from:
    #0 0x49451d in malloc (/root/curl/build2-afl/src/curl+0x49451d)
    #1 0x99323a in Curl_hash_init /root/curl/build2-afl/lib/../../lib/hash.c:73:14

Indirect leak of 16385 byte(s) in 1 object(s) allocated from:
    #0 0x49451d in malloc (/root/curl/build2-afl/src/curl+0x49451d)
    #1 0x8e1d21 in Curl_open /root/curl/build2-afl/lib/../../lib/url.c:602:24

Indirect leak of 5912 byte(s) in 1 object(s) allocated from:
    #0 0x494692 in calloc (/root/curl/build2-afl/src/curl+0x494692)
    #1 0x8e1ad7 in Curl_open /root/curl/build2-afl/lib/../../lib/url.c:584:10
    #2 0x6b6595 in Curl_conncache_init /root/curl/build2-afl/lib/../../lib/conncache.c:120:27

Indirect leak of 408 byte(s) in 1 object(s) allocated from:
    #0 0x494692 in calloc (/root/curl/build2-afl/src/curl+0x494692)
    #1 0x5f5739 in Curl_multi_handle /root/curl/build2-afl/lib/../../lib/multi.c:349:30
    #2 0x521e57 in operate /root/curl/build2-afl/src/../../src/tool_operate.c:2486:18

Indirect leak of 256 byte(s) in 1 object(s) allocated from:
    #0 0x49451d in malloc (/root/curl/build2-afl/src/curl+0x49451d)
    #1 0x8e1d95 in Curl_open /root/curl/build2-afl/lib/../../lib/url.c:608:30

Indirect leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x494692 in calloc (/root/curl/build2-afl/src/curl+0x494692)
    #1 0x6ad036 in Curl_resolver_init /root/curl/build2-afl/lib/../../lib/asyn-thread.c:116:15

SUMMARY: AddressSanitizer: 55457 byte(s) leaked in 8 allocation(s).

I expected the following

No memory leak.

curl/libcurl version

git commit 249f7b.

curl 7.68.0-DEV (x86_64-pc-linux-gnu) libcurl/7.68.0-DEV zlib/1.2.11
Release-Date: [unreleased]
Protocols: dict file ftp gopher http imap pop3 rtsp smtp telnet tftp
Features: AsynchDNS IPv6 Largefile libz UnixSockets

operating system

Ubuntu

test0075.conf

MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwpDa6CnVyPWpo
aGhoaGhoaGhbaGgy9Qohf/91MjakFroKdXI9ak9PT08KdXI9IuAn/6B3rwrwfgr/hc0e4BADagoA
8+3G7yKVCv+Gd/UKdXI9ak9PT08KLYpyNmiAujpcav7/hncc7unQ/+8ClQr/hneVAOtyPWpPT09P
Ci11cjZofxo6XDci698b62RoJ/+Gd6IK69/562RoJ//v2JUK/xKVav6GAAKGdxAKIioKlfp1cj06
AAHYlQr/hneVCnVyPZUK9SHbLVdyNqQiugrcCk2ZYo7UC60VDBsbMjakNrr1iorClU9PsLAKdf//
f/8n/3l3ogoQfz0i1fV3A3VyPSIKdXI9IioKi/p1cj0i9dJNgOOzKhOAnM1qcv8jIioKlPoK/4Z3
lQp1cj0i6d8ALZHnc///zw/tJGR3lQp1iIiIiIiIiIiIiIiIiIiIiIiIiIiIiHI9ak8K/4Z3lQAB
cj1qTzZPPwotdXI2aH8aOlw3IuvfG+tkaCffhneiCnVyPSIqCpX6dXI9IvXSTYDjsyr4EmMylfX/
IyKBgND/77qV+P94iGoKdXI9ak9PT08KdXI9IuAQAGrfFQz1tfU8Ci2i+3cK/4Z3lQp1cj2WT0+V
lwHYlQoEhneGCnVyPWr1CrCuNrp1cj11cj0iKgpNZE1NTU41TU1NTU3e3t6+3op1OqLyzelofP35
//Ptxu8ilQr/dXeV9YqNwmpPT0dPCi3jsyr47ZzNlXL/IyIqCpX6c3I9IgotWqUA+fEyCgp1lZWV
ebX1PAotOvvv2JUC/4Z3lZV5lZWVlXaVKgdjgPMSxulapQD58TIKlZUy9QohJB5pMjakNqcKdXI9
ak9PT08KdXI9IuAn3/nrZGgl/+/YlQr/EpVrEIZ3avWQjT0i6d8SlZUBhjAnahP/hoKVCnVyPQAA
/v/uhneoCnWN/4Z3lQp1cj2WT0+VlwHYlQoEhneGCnVyPWr1CrBNTU1NGjpcNyLr3xvrZGgn34Z3
ogp1cj3dKgqV+nVyPSL2hncQCiIqCpX6dXJQOgAB2JUK/4Z3lQp1cj2VCvUh2y11cjakIroK3ApN
mWKO9wutFQwbGzI2pDa69YqKwpWwsLCwCnX//3//J/95d113YsWKb29vbyMAaIAAsEFqAIBPd/9J
YIDzEsbpWqUA+fEyCpWVlZJDw8PDw8PDw8PDTU1NTU1N3t7e3t5PCi14jcmXgBo6XD0i6f///JBv
kL4B3AotVAAAABCBgC//7wotOvvv2JUC/4Z3lZV5lZWVlXaVKgdjMvUKISQeaTI2pDanCnVyPWpP
T09PCnVyPSLgJ9/562RoJf/v2JUK/xKVav6Gd2r1kI09IunfEpWVAYYwJ2oT/2+ClQp1cj0AAP7/
7oZ3qAp1jcKV3nV1OqLpzelogxoKANivCv+Wd5UKdXI9ak9PT08KdXI9GtEu+BAQODTLEE7S8w66
CnWNSgwMDAwMFgwMJQCH3OyqcAyFDAwMDAwMDAwq+BJjMmpy/yMiKgqV+gr/hneVCnVyPSLpPyzp
IO0AIGSbm2xkZGRgZJubZGSVAfvtxtuVsK42unVyPWr1Eu7bLU1vTU1NTjo6Ojo6Ojo6Ojo6Ojo6
Ojo6Ojo6TU1hsrKy3iEh3t51dTqi6c3pd5UK3ZV/GjpcyCLr3xvrZGgn/yL10meA47Mq+BJjMmoK
/yMigYDQ/++6lHj/hneiCnVyPSIqCpX6dYpC3QrSTYDj8yr+/+6Jd2r6dXI93QotWqUA+fEyCoGA
0P/v2JUK/5Z3lQp1cj1qT09PTwp1cj0a0S74EBA4NMsQTtLzDroKdY1Kzw/tJGR3lQp1c4MaCgDz
7cbvGxsbG4Z3lQp1cj1qT09PTwotdY3Jl4C6Olxq/v+Gdxzu6dD/7wKVCv+Gd5UAAXI9ak9PT08K
LXVyNmh/GjpcNyLr3xvrZGgn/4Z3ogp1cj0Ougp1jUrPD+0iKgqV+nVyPcWKb29vbyMAaIAAsEFq
AIBPj4+Pj4+Pj4+Pj4+Pj4+Pj4+Pd/9JYIDzEsbpIO2DZNLS0tLS0tLS/xMtwiDE0tLL0szS0tLS
0tLQ1dLS0tLSZGRkbGRk62RGZGRkTpUnlWqAQAsj7AAA+gHyKBIKh38=
@geeknik
Copy link
Author

geeknik commented Dec 31, 2019 •
edited
Loading

And $ echo "LUY9CnVyIDA=" | base64 -d > test0061.conf && ./curl -q -K test0061.conf file:///dev/null produces this leak in mime.c:

curl: (7) Failed to connect to 0 port 80: Connection refused

=================================================================
==2511==ERROR: LeakSanitizer: detected memory leaks

Indirect leak of 448 byte(s) in 1 object(s) allocated from:
    #0 0x49451d in malloc (/root/curl/build2-afl/src/curl+0x49451d)
    #1 0x6c51eb in curl_mime_addpart /root/curl/build2-afl/lib/../../lib/mime.c:1252:28

Indirect leak of 104 byte(s) in 1 object(s) allocated from:
    #0 0x49451d in malloc (/root/curl/build2-afl/src/curl+0x49451d)
    #1 0x6c4e6c in curl_mime_init /root/curl/build2-afl/lib/../../lib/mime.c:1215:24

Indirect leak of 1 byte(s) in 1 object(s) allocated from:
    #0 0x49451d in malloc (/root/curl/build2-afl/src/curl+0x49451d)
    #1 0x6c353b in curl_mime_data /root/curl/build2-afl/lib/../../lib/mime.c:1318:18

SUMMARY: AddressSanitizer: 553 byte(s) leaked in 3 allocation(s).

@bagder
Copy link
Member

bagder commented Jan 4, 2020

I believe these are two separate issues. I've reproduced the first one.

bagder added a commit that referenced this issue Jan 4, 2020
@bagder
curl: cleanup multi handle on failure
6114e6c 
... to fix memory leak in error path.

Fixes #4772
Reported-by: Brian Carpenter
This was referenced Jan 4, 2020
Closed
Closed
@bagder bagder changed the title Memory leaks curl tool parallel transfer memory leaks Jan 4, 2020
@bagder bagder closed this as completed in 271ec6b Jan 4, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cmdline tool memory-leak
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

curl: cleanup multi handle on failure curl/curl
3 participants
@bagder @geeknik @jay