public headers use non-curl prefixed symbols #4793

bagder · 2020-01-07T07:27:32Z

All symbols curl defines and provides in public include files/headers should be prefixed by curl or libcurl to minimize the risk of them colliding with other libraries' or applications' symbols.

This is mostly done already with a few exceptions (WIN32, CINIT, CFINIT and some of the related defines around the CINIT macro dance). This should be fixed and we should introduce a test that verifies that we maintain this situation going forward.


        test1167: verify global symbols in public headers are curl prefixed

... using the new badsymbols.pl perl script Fixes #4793

bagder · 2020-01-07T10:04:26Z

What triggered me to go down this rabbit hole this time here was how this mistake slipped in. the fix


        test1167: verify global symbols in public headers are curl prefixed

... using the new badsymbols.pl perl script Fixes #4793 Closes #4794

bagder added the libcurl API label Jan 7, 2020

bagder self-assigned this Jan 7, 2020

bagder mentioned this issue Jan 7, 2020

Make all public symbols curl prefixed #4794

Closed

bagder closed this in fb723fd Jan 9, 2020

lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020

curl / curl

public headers use non-curl prefixed symbols #4793

public headers use non-curl prefixed symbols #4793

bagder commented Jan 7, 2020

bagder commented Jan 7, 2020

curl / curl

Sponsor curl/curl

Join GitHub today

public headers use non-curl prefixed symbols #4793

public headers use non-curl prefixed symbols #4793

Comments

bagder commented Jan 7, 2020

bagder commented Jan 7, 2020