Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURLOPT_ALTSVC_CTRL man page: DEFAULT is incorrect #4909

Closed
candrews opened this issue Feb 11, 2020 · 0 comments
Closed

CURLOPT_ALTSVC_CTRL man page: DEFAULT is incorrect #4909

candrews opened this issue Feb 11, 2020 · 0 comments

Comments

@candrews
Copy link

@candrews candrews commented Feb 11, 2020

I did this

https://curl.haxx.se/libcurl/c/CURLOPT_ALTSVC_CTRL.html says:

DEFAULT
0. No Alt-Svc treatment.

But, the code says https://github.com/curl/curl/blob/curl-7_68_0/lib/altsvc.c#L256 :

  /* set default behavior */
  asi->flags = CURLALTSVC_H1
#ifdef USE_NGHTTP2
    | CURLALTSVC_H2
#endif
#ifdef ENABLE_QUIC
    | CURLALTSVC_H3
#endif

So the documented default is wrong.

I expected the following

The documentation to be agree with the code :)

curl/libcurl version

$ curl --version
curl 7.68.0 (x86_64-pc-linux-gnu) libcurl/7.68.0 OpenSSL/1.1.1d zlib/1.2.11 brotli/1.0.7 libidn2/2.3.0 libssh2/1.9.0_DEV nghttp2/1.40.0 quiche/0.2.0 librtmp/2.3
Release-Date: 2020-01-08
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtmp rtsp scp sftp smtp smtps telnet tftp 
Features: alt-svc AsynchDNS brotli HTTP2 HTTP3 HTTPS-proxy IDN IPv6 Largefile libz Metalink NTLM SSL TLS-SRP UnixSockets

operating system

# uname -a
Linux irrational 5.4.0-rc6 #2 SMP Fri Nov 8 19:09:49 EST 2019 x86_64 Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz GenuineIntel GNU/Linux
bagder added a commit that referenced this issue Feb 11, 2020
Reported-by: Craig Andrews
Fixes #4909
bagder added a commit that referenced this issue Feb 11, 2020
Assisted-by: Jay Satiro
Reported-by: Craig Andrews
Fixes #4909
@bagder bagder closed this in 8957e6e Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.