Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtests: log/curl.log doesn't exist! #4911

Closed
bagder opened this issue Feb 11, 2020 · 4 comments
Closed

runtests: log/curl.log doesn't exist! #4911

bagder opened this issue Feb 11, 2020 · 4 comments
Labels
regression tests

Comments

@bagder
Copy link
Member

@bagder bagder commented Feb 11, 2020 •
edited

I did this

cd tests && ./runtests.pl 1

I expected the following

There should be a log file left after the run, called tests/log/curl.log showing each command line invoke done in the test. The file doesn't exist.

curl/libcurl version

current git master, but I believe this flaw has existed for a while. I cannot remember at which point it broke. It used to work.

operating system

Linux, but I think it might exist everywhere.
@bagder

This comment has been minimized.

Sign in to view
Copy link
Member Author

@bagder bagder commented Feb 11, 2020

This puzzles me and I don't really have any good ideas how to debug it. What could possibly make it behave like this?
@emilengler

This comment has been minimized.

Sign in to view
Copy link
Contributor

@emilengler emilengler commented Feb 11, 2020

This puzzles me and I don't really have any good ideas how to debug it. What could possibly make it behave like this?

I may be totally wrong on this as I have absolutely no experience with Perl and how it behaves but as far as I looked at the code, the CMDLOG file stream was already used in function on line ~3000. However the file stream is being created in line ~5000. Maybe the runtime doesn't even have access to the variable yet. Maybe move the function a bit down.
@bagder

This comment has been minimized.

Sign in to view
Copy link
Member Author

@bagder bagder commented Feb 11, 2020

  1. It used to work
  2. They're used in the correct order, so the filehandle is created before it gets used and it seems to be closed after all uses of it.
bagder added a commit that referenced this issue Feb 27, 2020
@bagder
runtests: restore the command log
Verified
This commit was signed with a verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
Loading status checks…
db9bf10 
The log file with all command lines for the invoked command lines is now
called logs/commands.log

Fixes #4911
@bagder bagder mentioned this issue Feb 27, 2020
Closed
@bagder

This comment has been minimized.

Sign in to view
Copy link
Member Author

@bagder bagder commented Feb 27, 2020

For the record: commit 6617db6 (June 27, 2019) broke it
@bagder bagder closed this in 02988b7 Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression tests
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

runtests: restore the command log
2 participants
@bagder @emilengler
You can’t perform that action at this time.