Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alt-svc: should save cache "atomically" #4936

Closed
bagder opened this issue Feb 17, 2020 · 0 comments
Closed

alt-svc: should save cache "atomically" #4936

bagder opened this issue Feb 17, 2020 · 0 comments
Assignees
@bagder

Comments

@bagder
Copy link
Member

bagder commented Feb 17, 2020

As is being done for cookies in #4926, we should also change the alt-svc cache saving to make sure it gets done atomically to better work reliably with multiple threads reading/writing the file.
@bagder bagder self-assigned this Feb 17, 2020
bagder added a commit that referenced this issue Feb 17, 2020
@bagder
altsvc: make saving the cache an atomic operation
dc98851 
... by writing the file to temp name then rename to the final when done.

Fixes #4936
@bagder bagder mentioned this issue Feb 17, 2020
Closed
bagder added a commit that referenced this issue Feb 17, 2020
@bagder
altsvc: make saving the cache an atomic operation
3004b0b 
... by writing the file to temp name then rename to the final when done.

Fixes #4936
@bagder bagder closed this as completed in 14916a8 Feb 18, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bagder bagder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

altsvc: save the file atomically with final rename curl/curl
1 participant
@bagder