-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
compiler error with icc on Linux #5096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That |
Actually, I got it the other way around, it works if I define it. |
Where do you define it then so that it works? Isn't the logic in warnless.c enough to get it defined for icc? |
Ah, that define only works for warnless.c, while your error above is for mime.c... |
I define it through the CFLAGS in the configure script. Since the defines are in the warnless.h header, it looks ok so far. |
But why is that |
Because without it, the
in '/usr/include/netinet/in.h' get rewritten into
which is a syntax error. Now, I've read that on some platforms. |
What happens if you remove those defines and build with this patch? diff --git a/lib/warnless.h b/lib/warnless.h
index ea4c4395d..ab78f9448 100644
--- a/lib/warnless.h
+++ b/lib/warnless.h
@@ -92,21 +92,8 @@ void curlx_FD_ZERO(fd_set *fdset);
unsigned short curlx_htons(unsigned short usnum);
unsigned short curlx_ntohs(unsigned short usnum);
-#ifndef BUILDING_WARNLESS_C
-# undef FD_ISSET
-# define FD_ISSET(a,b) curlx_FD_ISSET((a),(b))
-# undef FD_SET
-# define FD_SET(a,b) curlx_FD_SET((a),(b))
-# undef FD_ZERO
-# define FD_ZERO(a) curlx_FD_ZERO((a))
-# undef htons
-# define htons(a) curlx_htons((a))
-# undef ntohs
-# define ntohs(a) curlx_ntohs((a))
-#endif
-
#endif /* __INTEL_COMPILER && __unix__ */
#endif /* HEADER_CURL_WARNLESS_H */ |
@aminiussi we need your assistance with this issue or it will get closed. We don't have access to icc nor any CI or autobuilds using it. |
@bagder sorry, I'll test test the patch in the afternoon. |
Build with the patch wen ok on the last git pull. Not all test passes, but that is due to valgrind:
Thx |
I'll cook up a proper PR with both these changes. Test 117 has no problems with or without valgrind for others. Maybe a problem with icc and valgrind? |
Reported-by: Alain Miniussi Fixes #5096
... as it apparently isn't (always) supported. Reported-by: Alain Miniussi Fixes #5096
Yes, our centos distribution valgrind is not compatible with icc. I just relaunched with locally compiled valgrind. |
Tests looks ok with a more recent valgrind. |
Reported-by: Alain Miniussi Fixes #5096
I did this
with CC=icc and:
I got:
Once I preprocessed explicitly with -E, it appear that the compile code was:
Which can be explained by:
I expected the following
A nice build
curl/libcurl version
https://github.com/curl/curl/releases/download/curl-7_69_1/curl-7.69.1.tar.gz
operating system
Linux gemini 3.10.0-693.2.2.el7.x86_64 #1 SMP Tue Sep 12 22:26:13 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
The text was updated successfully, but these errors were encountered: