Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windres: error: invalid output format: `COFF' #5099

Closed
nu8 opened this issue Mar 14, 2020 · 2 comments
Closed

windres: error: invalid output format: `COFF' #5099

nu8 opened this issue Mar 14, 2020 · 2 comments
Labels

Comments

@nu8
Copy link

@nu8 nu8 commented Mar 14, 2020

Currently Mingw cURL call Windres like this:

curl/lib/Makefile.m32

Lines 101 to 102 in 0845ecb

RC = $(CROSSPREFIX)windres
RCFLAGS = --include-dir=$(PROOT)/include -DDEBUGBUILD=0 -O COFF

but the output should actually be spelled coff, lower case:

https://sourceware.org/binutils/docs/binutils/windres.html

and in fact will fail with certain compilers:

$ cd lib
$ mingw32-make -f Makefile.m32
[...]
windres --include-dir=../include -DDEBUGBUILD=0 -O COFF -F pe-x86-64
   -i libcurl.rc -o libcurl.res
windres: error: invalid output format: `COFF'
mingw32-make: *** [Makefile.m32:378: libcurl.res] Error 1

https://github.com/mstorsjo/llvm-mingw

@nu8
Copy link
Author

@nu8 nu8 commented Mar 14, 2020

This seems to be a workaround:

mingw32-make -f Makefile.m32 RCFLAGS='-O coff'
jay added a commit to jay/curl that referenced this issue Mar 14, 2020
- s/COFF/coff/

Some versions of windres do not recognize uppercase COFF as a valid
way to specify the COFF output format.

Reported-by: Steven Penny

Fixes curl#5099
Closes #xxxx
@jay
Copy link
Member

@jay jay commented Mar 14, 2020

Please try #5101

@jay jay closed this in 67f3f6c Mar 14, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.