SMB tests on Debian?

[bagder]

I did this

apt install python3-impacket

cd tests && ./runtests.pl 1451

Python package impacket needs to be installed!
Use pip or your package manager to install it.
RUN: failed to start the SMB server

(I could run them fine before 4be2560)

I expected the following

To be able to run test 1451

curl/libcurl version

Current git master

operating system

Debian Linux, unstable. Updated just now.

cc: @mback2k

[bagder]

Also, I think the tests/README should be updated with the impacket info.

[mback2k]

(Y)our Python is still at version 2, so you need to install python-impacket instead of python3-impacket.

I will do a follow-up PR for tests/README and additional CI installs.

[bagder]

There is no python-impacket anymore, only python3-impacket.

[mback2k]

Then you will have to a wait a little until I have ported our smbserver.py to Python 3. ;-)

[bagder]

(strictly speaking, I think it is a regression even if you're on track of fixing it...)

[mback2k]

I don't think so, as smbserver.py was never Python 3 compatible and you could also just install the Python 2 version of impacket via pip2 install impacket.

Edit: I updated the labels to better reflect the situation being a mix of regression and enhancement.