Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMB tests on Debian? #5104

Closed
bagder opened this issue Mar 15, 2020 · 9 comments
Closed

SMB tests on Debian? #5104

bagder opened this issue Mar 15, 2020 · 9 comments

Comments

@bagder
Copy link
Member

@bagder bagder commented Mar 15, 2020

I did this

apt install python3-impacket

cd tests && ./runtests.pl 1451

Python package impacket needs to be installed!
Use pip or your package manager to install it.
RUN: failed to start the SMB server

(I could run them fine before 4be2560)

I expected the following

To be able to run test 1451

curl/libcurl version

Current git master

operating system

Debian Linux, unstable. Updated just now.

cc: @mback2k

@bagder bagder added the tests label Mar 15, 2020
@bagder

This comment has been minimized.

Copy link
Member Author

@bagder bagder commented Mar 15, 2020

Also, I think the tests/README should be updated with the impacket info.

@bagder bagder added the regression label Mar 15, 2020
@mback2k

This comment has been minimized.

Copy link
Member

@mback2k mback2k commented Mar 15, 2020

(Y)our Python is still at version 2, so you need to install python-impacket instead of python3-impacket.

I will do a follow-up PR for tests/README and additional CI installs.

@mback2k mback2k added not-a-bug and removed regression labels Mar 15, 2020
@mback2k mback2k self-assigned this Mar 15, 2020
@bagder

This comment has been minimized.

Copy link
Member Author

@bagder bagder commented Mar 15, 2020

There is no python-impacket anymore, only python3-impacket.

@mback2k

This comment has been minimized.

Copy link
Member

@mback2k mback2k commented Mar 15, 2020

Then you will have to a wait a little until I have ported our smbserver.py to Python 3. ;-)

@bagder

This comment has been minimized.

Copy link
Member Author

@bagder bagder commented Mar 15, 2020

(strictly speaking, I think it is a regression even if you're on track of fixing it...)

@mback2k

This comment has been minimized.

Copy link
Member

@mback2k mback2k commented Mar 15, 2020

I don't think so, as smbserver.py was never Python 3 compatible and you could also just install the Python 2 version of impacket via pip2 install impacket.

Edit: I updated the labels to better reflect the situation being a mix of regression and enhancement.

@bagder

This comment has been minimized.

Copy link
Member Author

@bagder bagder commented Mar 15, 2020

you could also just install the Python 2 version of impacket via pip2 install impacket

That was not conveyed until now...

@mback2k

This comment has been minimized.

Copy link
Member

@mback2k mback2k commented Mar 15, 2020

That was not conveyed until now...

Sorry for that, I should have explained that earlier.

@mback2k

This comment has been minimized.

Copy link
Member

@mback2k mback2k commented Mar 15, 2020

New issue for impacket due to missing dependency in their setup.py: SecureAuthCorp/impacket#798

mback2k added a commit to mback2k/curl that referenced this issue Mar 15, 2020
Update smbserver.py and negtelnetserver.py to be compatible with
Python 3 while staying backwards-compatible to support Python 2.

Tested with both Python 2.7.17 and Python 3.7.7

Fixes curl#5104
mback2k added a commit to mback2k/curl that referenced this issue Mar 17, 2020
Update smbserver.py and negtelnetserver.py to be compatible with
Python 3 while staying backwards-compatible to support Python 2.

Tested with both Python 2.7.17 and Python 3.7.7
travis-ci still uses Python 2 and CirrusCI uses Python 3

Fixes curl#5104
mback2k added a commit to mback2k/curl that referenced this issue Mar 17, 2020
Update smbserver.py and negtelnetserver.py to be compatible with
Python 3 while staying backwards-compatible to support Python 2.

Tested with both Python 2.7.17 and Python 3.7.7
travis-ci still uses Python 2 and CirrusCI uses Python 3

Reported-by: Daniel Stenberg
Reviewed-by: Kamil Dudka
Reviewed-by: Marcel Raad

Fixes curl#5104
Closes curl#5110
mback2k added a commit to mback2k/curl that referenced this issue Mar 17, 2020
Update smbserver.py and negtelnetserver.py to be compatible with
Python 3 while staying backwards-compatible to support Python 2.

Tested with both Python 2.7.17 and Python 3.7.7
travis-ci still uses Python 2 and CirrusCI uses Python 3

Reported-by: Daniel Stenberg
Reviewed-by: Kamil Dudka
Reviewed-by: Marcel Raad

Fixes curl#5104
Closes curl#5110
mback2k added a commit to mback2k/curl that referenced this issue Mar 17, 2020
Update smbserver.py and negtelnetserver.py to be compatible with
Python 3 while staying backwards-compatible to support Python 2.

Tested with both Python 2.7.17 and Python 3.7.7
travis-ci still uses Python 2 and CirrusCI uses Python 3

Reported-by: Daniel Stenberg
Reviewed-by: Kamil Dudka
Reviewed-by: Marcel Raad

Fixes curl#5104
Closes curl#5110
mback2k added a commit to mback2k/curl that referenced this issue Mar 17, 2020
Update smbserver.py and negtelnetserver.py to be compatible with
Python 3 while staying backwards-compatible to support Python 2.

Tested with both Python 2.7.17 and Python 3.7.7
travis-ci still uses Python 2 and CirrusCI uses Python 3

Reported-by: Daniel Stenberg
Reviewed-by: Kamil Dudka
Reviewed-by: Marcel Raad

Fixes curl#5104
Closes curl#5110
mback2k added a commit to mback2k/curl that referenced this issue Mar 18, 2020
Update smbserver.py and negtelnetserver.py to be compatible with
Python 3 while staying backwards-compatible to support Python 2.

Tested with both Python 2.7.17 and Python 3.7.7
travis-ci still uses Python 2 and CirrusCI uses Python 3

Reported-by: Daniel Stenberg
Reviewed-by: Kamil Dudka
Reviewed-by: Marcel Raad

Fixes curl#5104
Closes curl#5110
mback2k added a commit to mback2k/curl that referenced this issue Mar 18, 2020
Update smbserver.py and negtelnetserver.py to be compatible with
Python 3 while staying backwards-compatible to support Python 2.

Tested with both Python 2.7.17 and Python 3.7.7
travis-ci still uses Python 2 and CirrusCI uses Python 3

Reported-by: Daniel Stenberg
Reviewed-by: Kamil Dudka
Reviewed-by: Marcel Raad

Fixes curl#5104
Closes curl#5110
@mback2k mback2k closed this in 3c9066f Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.