Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngtcp2 CI build fails due to modified API #5166

Closed
bagder opened this issue Mar 30, 2020 · 0 comments
Closed

ngtcp2 CI build fails due to modified API #5166

bagder opened this issue Mar 30, 2020 · 0 comments
Labels
build HTTP/3 h3 or quic related

Comments

@bagder
Copy link
Member

bagder commented Mar 30, 2020

I did this

The CI build that builds with ngtcp2 started to fail since this upstream commit: ngtcp2/ngtcp2@32e7031 by @tatsuhiro-t
@bagder bagder added the build label Mar 30, 2020
@bagder bagder changed the title ngtcp2 CI build fails ngtcp2 CI build fails due to modified API Mar 30, 2020
@bagder bagder added the HTTP/3 h3 or quic related label Mar 30, 2020
@bagder bagder mentioned this issue Mar 30, 2020
Closed
ueno added a commit to ueno/curl that referenced this issue Mar 30, 2020
@ueno
ngtcp2: update to git master for the key installation API change
691e22b 
This updates the ngtcp2 OpenSSL backend to follow the API change in
commit 32e703164 of ngtcp2.

Notable changes are:
- ngtcp2_crypto_derive_and_install_{rx,tx}_key have been added to replace
  ngtcp2_crypto_derive_and_install_key
- the 'side' argument of ngtcp2_crypto_derive_and_install_initial_key
  has been removed

Closes curl#5166
@ueno ueno mentioned this issue Mar 30, 2020
Closed
@bagder bagder closed this as completed in 8efd26a Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build HTTP/3 h3 or quic related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ngtcp2: update to git master for the key installation API change ueno/curl
1 participant
@bagder