Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl doesn't hide the username and password from the ps output #5470

Closed
huzunhao opened this issue May 28, 2020 · 0 comments
Closed

curl doesn't hide the username and password from the ps output #5470

huzunhao opened this issue May 28, 2020 · 0 comments
Labels
build cmdline tool regression

Comments

@huzunhao
Copy link

I did this

1、transfering the files,the commands :
create upgrade session session=hotpatch ip=50.64.130.84 user=admin password=***** path=/SPH1.tgz
2、The ps command looks at the curl thread
ps -ef | grep curl

I expected the following

hiding password

curl/libcurl version

curl-7.69.1
[curl -V output]
curl-7.69.1

operating system

Storage:~/huzunhao # uname -a
Linux Storage 4.19.36-vhulk1907.1.0.h453.eulerosv2r8.aarch64 #1 SMP Mon Jul 22 00:00:00 UTC 2019 aarch64 aarch64 aarch64 [GNU/Linux](url)
bagder added a commit that referenced this issue May 28, 2020
@bagder
configure: repair the check if argv can be written to
6b42584 
Due to bad escaping of the test code, the test wouldn't build and thus
result in a negative test result, which would lead to the unconditional
assumption that overwriting the arguments doesn't work and thus curl
would never hide credentials given in the command line, even when it
would otherwise be possible.

Regression from commit 2d4c215

Reported-by: huzunhao on github
Fixes #5470
@bagder bagder mentioned this issue May 28, 2020
Closed
@bagder bagder changed the title curl:Curl doesn't enable the ability to hide the username and password, causing the password to appear in clear text during file transfer curl doesn't hide the username and password from the ps output May 28, 2020
@bagder bagder closed this as completed in 2110b99 May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build cmdline tool regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

configure: repair the check if argv can be written to curl/curl
2 participants
@bagder @huzunhao