Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support smbv2/3 and/or update documentation #5679

Closed
tbugfinder opened this issue Jul 13, 2020 · 6 comments
Closed

support smbv2/3 and/or update documentation #5679

tbugfinder opened this issue Jul 13, 2020 · 6 comments

Comments

@tbugfinder
Copy link

@tbugfinder tbugfinder commented Jul 13, 2020

I did this

Upload file from Linux to Windows share using curl.

I expected the following

Authentication applied successfully and file copied.

Apart from an issue there isn't proper documentation included (or I least I didn't notice it) that curl only supports smbv1. It would be very convenient if it would support SMBv2/3 as those are the protocols used.

curl/libcurl version

[curl -V output]
7.70

operating system

Linux

@bagder
Copy link
Member

@bagder bagder commented Jul 13, 2020

It is mentioned in the docs already. The question is where did you expect to find this detail where you didn't see it this time?

(We don't keep feature-request issues open in this tracker, as we reserve that for bugs and problems.)

@tbugfinder
Copy link
Author

@tbugfinder tbugfinder commented Jul 13, 2020

Usually I start off reading man pages.
There I didn't came across the limit.

@bagder
Copy link
Member

@bagder bagder commented Jul 13, 2020

The CURLOPT_URL documentation/man page includes this information: https://curl.haxx.se/libcurl/c/CURLOPT_URL.html

@tbugfinder
Copy link
Author

@tbugfinder tbugfinder commented Jul 14, 2020

@bagder
Copy link
Member

@bagder bagder commented Jul 14, 2020

And where in that page did you expect to find this information? Ie where would you say it would make sense to have it added?

bagder added a commit that referenced this issue Jul 15, 2020
Added protocol and version specific information about all protocols curl
supports.

Fixes #5679
Reported-by: tbugfinder on github
@tbugfinder
Copy link
Author

@tbugfinder tbugfinder commented Jul 16, 2020

like right at the top, indeed.

@bagder bagder closed this in d5814c0 Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.