Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most autobuilds failing because of TYPEDEFSTRUCT in stub_gssapi.h #5715

Closed
MarcelRaad opened this issue Jul 23, 2020 · 4 comments
Closed

Most autobuilds failing because of TYPEDEFSTRUCT in stub_gssapi.h #5715

MarcelRaad opened this issue Jul 23, 2020 · 4 comments
Assignees
Labels

Comments

@MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented Jul 23, 2020

I did this

Look at https://curl.haxx.se/dev/builds.html

I expected the following

Mostly green builds. All but one are red though because of a checksrc warning:

/tests/libtest/stub_gssapi.h:71:2: warning: typedef'ed struct (TYPEDEFSTRUCT)
typedef struct gss_buffer_desc_struct {
^
/tests/libtest/stub_gssapi.h:88:2: warning: typedef'ed struct (TYPEDEFSTRUCT)
typedef struct gss_OID_desc_struct {
^
/tests/libtest/stub_gssapi.h:93:2: warning: typedef'ed struct (TYPEDEFSTRUCT)
typedef struct gss_channel_bindings_struct {
^

Also, is it expected that checksrc warnings, in contrast to compiler warnings, prevent running the tests?

curl/libcurl version

Everything still on the autobuilds page, which starts with 2020-07-10.

operating system

Linux, Windows, Solaris

@MarcelRaad MarcelRaad added the tests label Jul 23, 2020
@bagder
Copy link
Member

@bagder bagder commented Jul 26, 2020

Odd. tests/libtest/.checksrc already contains disable TYPEDEFSTRUCT but it seems it doesn't work on some builds?

@bagder
Copy link
Member

@bagder bagder commented Jul 27, 2020

@MarcelRaad I can see your build at https://curl.haxx.se/dev/log.cgi?id=20200727044957-11233#prob5 reproduces this. Can you repro manually, perhaps on the same host? If so, can you figure out why the disabling of that warning doesn't work there?

@MarcelRaad
Copy link
Member Author

@MarcelRaad MarcelRaad commented Jul 31, 2020

I can reproduce it on any machine with testcurl.pl:

./tests/testcurl.pl --configure="--enable-debug --enable-static --disable-shared" --runtestopts="-a"
[...]
make[2]: Leaving directory '/build-12975/tests/unit'
make[2]: Entering directory '/build-12975/tests'
cd libtest && make checksrc
make[3]: Entering directory '/build-12975/tests/libtest'
  RUN      checksrc
/tests/libtest/stub_gssapi.h:71:2: warning: typedef'ed struct (TYPEDEFSTRUCT)

I haven't had the chance to look closer so far, but maybe it's something similar to #5288 (comment)?

@bagder bagder self-assigned this Jul 31, 2020
@bagder
Copy link
Member

@bagder bagder commented Jul 31, 2020

Thanks. I understand now...

bagder added a commit that referenced this issue Jul 31, 2020
Without the -D command line option, checksrc.pl won't know which
directory to load the ".checksrc" file from when building out of the
source tree.

Reported-by: Marcel Raad
Fixes #5715
@bagder bagder closed this in faeec84 Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.