Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl_easy_reset : fix HTTP Retry mechanism #5974

Closed
FreeYourSoul opened this issue Sep 17, 2020 · 2 comments
Closed

curl_easy_reset : fix HTTP Retry mechanism #5974

FreeYourSoul opened this issue Sep 17, 2020 · 2 comments
Labels

Comments

@FreeYourSoul
Copy link

@FreeYourSoul FreeYourSoul commented Sep 17, 2020

I did this

By using the easy interface, I was using the same http connection (and reset it a each use) in order to not waste resources starting connection over and over, working perfectly fine on version 7.70, since version 7.72, it didn't work anymore

The issue

The issue is comming from the retry mechanism that has been re factorized, the retry is now set in the state data of the connection in
conn->state.retrycount.
But the issue is that this new value introduced is not reset to 0 when calling curl_easy_reset, which makes project using this reset feature not working anymore

curl/libcurl version

7.72

I attach the fix directly to this issue

@bagder
Copy link
Member

@bagder bagder commented Sep 17, 2020

Forgot the attachment?

@FreeYourSoul
Copy link
Author

@FreeYourSoul FreeYourSoul commented Sep 17, 2020

#5975

Sorry, you commented faster than I do the PR.

@bagder bagder linked a pull request that will close this issue Sep 17, 2020
@bagder bagder closed this in 7921b41 Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.