Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test 2100 occasionally makes two POST requests #6042

Closed
bagder opened this issue Oct 4, 2020 · 0 comments
Closed

Test 2100 occasionally makes two POST requests #6042

bagder opened this issue Oct 4, 2020 · 0 comments
Labels
CI Continuous Integration name lookup DNS and related tech tests

Comments

@bagder
Copy link
Member

bagder commented Oct 4, 2020

I did this

I checked recent travis CI builds. Spotted that the ASAN builds often cause test 2100 to fail and the stderr output and HTTP server log then show that curl issued two DoH POSTs instead of the single expected one. The test runs with "forced IPv4" using -4.

example log

I have not been able to reproduce this failure locally on my Linux boxes.

I expected the following

Test 2100 should always run green.

curl/libcurl version

current git master on travis

operating system

The ASAN builds only run on Linux.
@bagder bagder added tests name lookup DNS and related tech CI Continuous Integration labels Oct 4, 2020
bagder added a commit that referenced this issue Oct 4, 2020
@bagder
curl: make sure setopt CURLOPT_IPRESOLVE passes on a long
fcee05b 
Previously, it would pass on a define (int) which could make libcurl
read junk as a vaulue - which prevented the CURLOPT_IPRESOLVE option to
"take". This could then make test 2100 do two DoH requests instead of
one!

Fixes #6042
@bagder bagder mentioned this issue Oct 4, 2020
Closed
@bagder bagder closed this as completed in ec1cb75 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration name lookup DNS and related tech tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

curl: make sure setopt CURLOPT_IPRESOLVE passes on a long curl/curl
1 participant
@bagder