Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libCurl 7.73.0 CHKSTRINGS failure on OS400 #6083

Closed
jonrumsey opened this issue Oct 15, 2020 · 1 comment
Closed

libCurl 7.73.0 CHKSTRINGS failure on OS400 #6083

jonrumsey opened this issue Oct 15, 2020 · 1 comment
Labels
build

Comments

@jonrumsey
Copy link
Contributor

@jonrumsey jonrumsey commented Oct 15, 2020

I did this

Attempted build of 7.73.0 on IBM i V7R3M0

I expected the following

Build aborted with;
CZS1607: Program CHKSTRINGS was created in library QMQMTMP on 10/14/20 at 09:23:48.
STRING_LASTZEROTERMINATED(77) is not expected value(76).…curl_easy_setopt_ccsid() in packages/OS400/ccsidcurl.c may need updating if new strings are provided as input via the curl API.…ERROR: CHKSTRINGS failed!

CURLOPT_SSL_EC_CURVES was added by #5892 but not added to ccsidcurl.c in packages/OS400.
EXPECTED_STRING_LASTZEROTERMINATED in chkstrings.c should now be (STRING_SSL_EC_CURVES + 1)

curl/libcurl version

libCurl 7.73.0

operating system

IBM i V7R3M0
@bagder bagder added the build label Oct 15, 2020
jay added a commit to jay/curl that referenced this issue Oct 15, 2020
@jay
os400: Sync libcurl API options
079cedc 
This fixes the OS400 build and also an incorrect entry for
CURLINFO_APPCONNECT_TIME_T where it was treated as
CURLINFO_STARTTRANSFER_TIME_T.

Reported-by: Jon Rumsey

Fixes curl#6083
Closes #xxxx
@jay jay mentioned this issue Oct 15, 2020
Closed
jay added a commit to jay/curl that referenced this issue Oct 16, 2020
@jay
os400: Sync libcurl API options
4e66fc0 
This fixes the OS400 build and also an incorrect entry for
CURLINFO_APPCONNECT_TIME_T where it was treated as
CURLINFO_STARTTRANSFER_TIME_T.

Reported-by: Jon Rumsey

Fixes curl#6083
Closes #xxxx
@jay jay closed this in 3bcd81d Oct 18, 2020
@jay
Copy link
Member

@jay jay commented Oct 18, 2020

Thanks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

os400: Sync libcurl API options
3 participants
@bagder @jay @jonrumsey