Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURL::libcurl INTERFACE_LINK_LIBRARIES uses -lpthread instead of Threads::Threads #6166

Closed
reddwarf69 opened this issue Nov 3, 2020 · 2 comments

Comments

@reddwarf69
Copy link
Contributor

Not sure why https://github.com/curl/curl/blob/master/CMakeLists.txt#L289 uses CMAKE_THREAD_LIBS_INIT when https://github.com/curl/curl/blob/master/CMakeLists.txt#L394 uses OpenSSL::SSL OpenSSL::Crypto.

At the very least this stop the user from getting the THREADS_PREFER_PTHREAD_FLAG usage honoured.

@bagder bagder added the cmake label Nov 3, 2020
@reddwarf69
Copy link
Contributor Author

reddwarf69 commented Nov 4, 2020

FWIW I am personally using https://github.com/RedDwarf69/curl/tree/cmake. I'm not creating PRs because I have not tried to make it ready for that (e.g I'm increasing the minimum required cmake version... and I have no idea how much you want to keep cmake 3.2 support).
I'm solving this with reddwarf69@d1f0314

@snikulov
Copy link
Member

snikulov commented Nov 5, 2020

@reddwarf69 you changes (at least use Threads::Threads) does not require the latest CMake. Imported target Threads::Threads already present since v3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants