Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
cmake: doesn't fail if zlib support is requested but the zlib library can't be found #6173
In general the checks are inconsistent. With
On autotools you have --with-zlib/--without-zlib and autodetection. If
I don't think we need to "blindly" follow and mimic autotools in cmake (as it certainly has its flaws and peculiarities as well), but the things that are done "right" and that we like we certainly could.
I think when a user asks for enabling a feature, like zlib, we should fail if that can't be done - using any build system. If the user doesn't ask for it, then detecting it automatically and using it or not based on that seems reasonable. Right?
I'm with @bagder . CMake build should probably behave "the CMake way" mimicking autotools where it makes sense.