Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests fail on macOS with c-ares 1.17.1 #6247

Closed
mback2k opened this issue Nov 25, 2020 · 5 comments
Closed

Some tests fail on macOS with c-ares 1.17.1 #6247

mback2k opened this issue Nov 25, 2020 · 5 comments

Comments

@mback2k
Copy link
Member

@mback2k mback2k commented Nov 25, 2020

I did this

See https://github.com/curl/curl/pull/6234/checks?check_run_id=1449769820

Test 506 fails for an (to me) unknown reason, the output order is invalid.
Tests 711 till 715 show a memory issue on macOS if build with c-ares.

I expected the following

Should be working correctly, or did something change recently?

curl/libcurl version

current master and PRs

operating system

macOS CI

@bagder bagder added CI tests labels Nov 26, 2020
@bagder
Copy link
Member

@bagder bagder commented Nov 26, 2020

That doesn't look like a stable nor frequent failure? Most CI rounds seem to do fine for those tests. I just ran those tests locally in c-ares builds on both mac and Linux here, and none of the tests failed even once (on current master).

./runtests.pl --repeat=21 -R 506 711 712 713 714 715
@mback2k
Copy link
Member Author

@mback2k mback2k commented Nov 26, 2020

I am seeing the same issue repeat for CI on master for at least these recent commits:
image

Maybe it is related to the c-ares version used in the CI?

@mback2k
Copy link
Member Author

@mback2k mback2k commented Nov 26, 2020

It actually looks like 37cdc2a introduced the CI failure.

@bagder
Copy link
Member

@bagder bagder commented Nov 26, 2020

I'll dig deeper.

@bagder
Copy link
Member

@bagder bagder commented Nov 26, 2020

I upgraded my mac's c-ares from 1.16.1 to 1.17.1 and test 506 started to fail. Works fine with 1.17.1 on Linux...

@bagder bagder changed the title Some tests failing on CI with c-ares Some tests fail on macOS with c-ares 1.17.1 Nov 26, 2020
@bagder bagder added name lookup and removed CI labels Nov 26, 2020
bagder added a commit that referenced this issue Nov 26, 2020
The resolve call is done with the right port number, but the subsequent
check used the wrong one, which then could find a previous resolve which
would return and leave the fresh resolve "incomplete" and leaking
memory.

Fixes #6247
@bagder bagder closed this in 72ae673 Nov 26, 2020
bagder added a commit that referenced this issue Nov 26, 2020
The resolve call is done with the right port number, but the subsequent
check used the wrong one, which then could find a previous resolve which
would return and leave the fresh resolve "incomplete" and leaking
memory.

Fixes #6247
Closes #6253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.