cmake fails because of reserved word usage

[Mipsters]

This seems like a problem any use of cmake would uncover, but I didn't see it mentioned anywhere

I did this

cmake ../curl-curl-7_73_0

I expected the following

created build files successfully

curl/libcurl version

7.73.0

[curl -V output]

-- The C compiler identification is GNU 3.3.5
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- curl version=[7.73.0-DEV]
-- Performing Test OPT_pedantic
-- Performing Test OPT_pedantic - Success
-- Performing Test OPT_Wall
-- Performing Test OPT_Wall - Success
-- Performing Test OPT_W
-- Performing Test OPT_W - Success
-- Performing Test OPT_Wpointer_arith
-- Performing Test OPT_Wpointer_arith - Success
-- Performing Test OPT_Wwrite_strings
-- Performing Test OPT_Wwrite_strings - Success
-- Performing Test OPT_Wunused
-- Performing Test OPT_Wunused - Success

...

-- Check size of struct sockaddr_storage
-- Check size of struct sockaddr_storage - done
-- Performing Test HAVE_POLL_FINE
-- Performing Test HAVE_POLL_FINE - Success
CMake Error at tests/CMakeLists.txt:34 (add_custom_target):
  The target name "test" is reserved or not valid for certain CMake features,
  such as generator expressions, and may result in undefined behavior.
Call Stack (most recent call first):
  tests/CMakeLists.txt:44 (add_runtests)


-- Enabled features: SSL IPv6 unix-sockets libz AsynchDNS NTLM HTTPS-proxy
-- Enabled protocols: DICT FILE FTP FTPS GOPHER HTTP HTTPS IMAP IMAPS MQTT POP3 POP3S RTSP SCP SFTP SMB SMBS SMTP SMTPS TELNET TFTP
-- Enabled SSL backends: OpenSSL
-- Configuring incomplete, errors occurred!

operating system

debian sarge 3.1
cmake: 3.6.3

Linux debian 2.4.27-3-386 #1 Wed Dec 6 00:38:33 UTC 2006 i686 GNU/Linux

my notes

this probably happens because of this line
(I used the 7_73_0 tag version but it's the same in master at the time of writing this bug report)
this stack overflow answer probably has the solution, but I don't know enough cmake to be sure
changing the line in tests/CMakeLists.txt to be

add_runtests(te-st           "")

passed the command successfully

[bagder]

This doesn't happen for me with cmake 3.18.4 and it doesn't fail in the CI builds so I presume this depends on the used cmake version.

[Mipsters]

this is odd, I'll try a newer version of cmake and see if it happens there too
but if it has anything to do with cmake version, maybe the minimum cmake version should be updated

[Mipsters]

I cannot update the cmake version at the same platform without a lot of effort (building cpp11 compatible compiler from source)
so I can't test this
I can ran more tests on my current setup if that's any help
if not, you can close the issue

[bagder]

Ideally someone can come up with a fix for all versions.