Python 2 support for tests #6259
Closed
Labels
Comments
No, please no more Python 2 support! It reached end of life on January 1st this year and I think we should accept that decision. |
I'm with @emilengler, I rather think we should work on making python2 fail gracefully. Although if someone wants to work on fixing python 2 stuff I won't stand in the way. It just seems like the wrong thing to put a lot of effort into. |
I am with @emilengler and @bagder, but will try to fix it anyway this time. |
mback2k
added a commit
to mback2k/curl
that referenced
this issue
Nov 30, 2020
Backporting the Python 3 implementation of setStream to ClosingFileHandler as a fallback within Python 2. Reported-by: Jay Satiro Fixes curl#6259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I did this
make test from master in Ubuntu 16.
This is a problem since #6206 landed. The error is from attempting to start the server and because it can't start the server I guess it doesn't count those tests. This error appears to be because Python 2 doesn't have setStream in StreamHandler.
Tests don't fail because of this, instead the server fails silently and it appears those tests don't run.
Also a problem in the CI.
We've had other issues with Python 2 , I think there was a problem with the SMB server as well. I think the larger issue is should Python 2 still be supported for tests. I would think if only because I have LTS builds that package it.
curl/libcurl version
Ubuntu 16 LTS
Python 2.7.12
curl 7.73.1-DEV (x86_64-pc-linux-gnu) libcurl/7.73.1-DEV OpenSSL/1.1.1h zlib/1.2.8 nghttp2/1.41.0 librtmp/2.3
/cc @mback2k
The text was updated successfully, but these errors were encountered: