-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake] Can't use feature ldaps on Windows #6284
Labels
Comments
It seems nobody is going to work on this. I'll add it to |
vszakats
added a commit
to vszakats/curl
that referenced
this issue
Mar 4, 2023
Before this patch, enabling LDAPS required a manual C flag: https://github.com/curl/curl-for-win/blob/c1cfc31cfc04f24f7a4f946564d6f0e1b4d7dd36/curl-cmake.sh#L105 Fix this and enable LDAPS automatically when using `wldap32` (and when not explicitly disabled). This matches autotools and `Makefile.mk` behavior. Also remove issue from KNOWN_BUGS. Reported-by: JackBoosY on github Fixes curl#6284
vszakats
added a commit
to curl/curl-for-win
that referenced
this issue
Mar 4, 2023
Proposing a fix for this in PR #10674. |
vszakats
added a commit
that referenced
this issue
Mar 5, 2023
Before this patch, enabling LDAPS required a manual C flag: https://github.com/curl/curl-for-win/blob/c1cfc31cfc04f24f7a4f946564d6f0e1b4d7dd36/curl-cmake.sh#L105 Fix this and enable LDAPS automatically when using `wldap32` (and when not explicitly disabled). This matches autotools and `Makefile.mk` behavior. Also remove issue from KNOWN_BUGS. Add workaround for MSVS 2010 warning triggered by LDAPS now enabled in more CI tests: `ldap.c(360): warning C4306: 'type cast' : conversion from 'int' to 'void *' of greater size` Ref: https://ci.appveyor.com/project/curlorg/curl/builds/46408284/job/v8mwl9yfbmoeqwlr#L312 Reported-by: JackBoosY on github Reviewed-by: Jay Satiro Reviewed-by: Marcel Raad Fixes #6284 Closes #10674
bch
pushed a commit
to bch/curl
that referenced
this issue
Jul 19, 2023
Before this patch, enabling LDAPS required a manual C flag: https://github.com/curl/curl-for-win/blob/c1cfc31cfc04f24f7a4f946564d6f0e1b4d7dd36/curl-cmake.sh#L105 Fix this and enable LDAPS automatically when using `wldap32` (and when not explicitly disabled). This matches autotools and `Makefile.mk` behavior. Also remove issue from KNOWN_BUGS. Add workaround for MSVS 2010 warning triggered by LDAPS now enabled in more CI tests: `ldap.c(360): warning C4306: 'type cast' : conversion from 'int' to 'void *' of greater size` Ref: https://ci.appveyor.com/project/curlorg/curl/builds/46408284/job/v8mwl9yfbmoeqwlr#L312 Reported-by: JackBoosY on github Reviewed-by: Jay Satiro Reviewed-by: Marcel Raad Fixes curl#6284 Closes curl#10674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi guys:
Recently, we received an issue about curl (microsoft/vcpkg#14030), that reported that the feature
ldaps
could not be enabled on Windows.Since curl in vcpkg uses cmake to build, I checked the cmake configuration in curl and found something strange:
curl/CMakeLists.txt
Lines 511 to 520 in abd846c
Here we can use the system's ldaps on windows, but openldap is not disabled here, and:
curl/CMakeLists.txt
Lines 1398 to 1400 in abd846c
There is no judgment variable
USE_WIN32_LDAP
when judging whether to enable ldaps.I think that's caused this issue.
But even if I use
USE_WIN32_LDAP
and explicitly enable ldaps in the configuration log, using curl -V does not explicitly enable ldaps.Configure log:
Result:
I expected the following
ldaps should be enabled on Windows.
curl/libcurl version
7.73.0
[curl -V output]
operating system
Windows 10, Visual Studio 2017, cmake 3.18.2
The text was updated successfully, but these errors were encountered: