Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: HTTP-only builds fail several --libcurl tests since CVE-2020-8284 #6303

Closed
bagder opened this issue Dec 11, 2020 · 0 comments
Closed

build: HTTP-only builds fail several --libcurl tests since CVE-2020-8284 #6303

bagder opened this issue Dec 11, 2020 · 0 comments
Labels
build tests

Comments

@bagder
Copy link
Member

bagder commented Dec 11, 2020

I did this

See an example CI build doing a HTTP-only configure and running the test suite.

I expected the following

Run fine

curl/libcurl version

git master

operating system

Any

Way of solution

Previously we've just removed lines that are conditionally output for --libcurl in as "lowest common denominator" style.

But I will go another route this time: In the bagder/hyper branch I have already introduced #ifdef-style logic and handling in test cases, so I'm going to move to merge that work independently and then have the FTP-specific lines in the --libcurl output simply depend on FTP being present in the build.
@bagder bagder mentioned this issue Dec 11, 2020
Closed
bagder added a commit that referenced this issue Dec 11, 2020
@bagder
tests: make --libcurl tests only test FTP options if ftp enabled
cd6ee87 
Adjust six --libcurl tests to only check the FTP option if FTP is
actually present in the build.

Fixes #6303
@bagder bagder mentioned this issue Dec 11, 2020
Closed
@bagder bagder closed this as completed in 3a63c19 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build tests
Projects
None yet
Milestone
No milestone
1 participant
@bagder