New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leak in Curl_override_sspi_http_realm #635
Comments
Ah. The default is a dup of a zero length string so it looks like that is possible. I think only if we are updating the domain pointer would we free the old one, so:
Can you try that? |
Yes, that works fine. Wouldn't it be better not initialize with strdup("") and just leave as NULL? Thanks, |
Free an existing domain before replacing it. Bug: #635 Reported-by: silveja1@users.noreply.github.com
No, we need a pointer to a domain even if it's zero length. There's no guarantee the domain will be replaced, that's why I changed it to free only if there's a replacement. Landed in 742deff, thanks! |
I've fixed a 1 byte memory leak with Curl_override_sspi_http_realm in curl_sasl_sspi.c on line 297. Without being intimately involved in the project I don't want to check it in.
Here is the fix:
The text was updated successfully, but these errors were encountered: