New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio project generator broken #649

Closed
jay opened this Issue Feb 13, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@jay
Member

jay commented Feb 13, 2016

>generate vc10
20743/ was unexpected at this time.

This is an unusual one. The command interpreter may still process special characters in REM comments in batch files, and in this case interprets a question mark in a URL as path globbing or some such.

>rem /?foo=bar/
bar/ was unexpected at this time.

Introduced in d49881c#diff-227457f73d3f44861a493547a1a5a59e

To remedy this I'm going to remove that NOTE. FYI @captain-caveman2k @vszakats

@jay jay closed this in 464a1d0 Feb 13, 2016

@mback2k

This comment has been minimized.

Show comment
Hide comment
@mback2k

mback2k Feb 13, 2016

Member

Thanks @jay. @captain-caveman2k and I always wondered why vc10 fails.

Member

mback2k commented Feb 13, 2016

Thanks @jay. @captain-caveman2k and I always wondered why vc10 fails.

@vszakats

This comment has been minimized.

Show comment
Hide comment
@vszakats

vszakats Feb 13, 2016

Member

@jay Sorry about this. Another, more generic solution would be to switch
to use :: as comment marker. It would resolve this issue and be more readable too.
It's supported way back into MS-DOS, so it should be safe:

:: https://blogs.msdn.microsoft.com/oldnewthing/20080926-00/?p=20743/
Member

vszakats commented Feb 13, 2016

@jay Sorry about this. Another, more generic solution would be to switch
to use :: as comment marker. It would resolve this issue and be more readable too.
It's supported way back into MS-DOS, so it should be safe:

:: https://blogs.msdn.microsoft.com/oldnewthing/20080926-00/?p=20743/
@vszakats

This comment has been minimized.

Show comment
Hide comment
@vszakats
Member

vszakats commented Feb 13, 2016

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Feb 13, 2016

Member

It's not your fault, just a bug. I would argue it's a Windows bug but the way they document it you can't really be sure. I've programmed a lot of batch and I've never seen that happen before. I don't think it's necessary to change all .bat comments from rem to :: to address this issue. That note is stale anyway since we no longer set the errorlevel.

Member

jay commented Feb 13, 2016

It's not your fault, just a bug. I would argue it's a Windows bug but the way they document it you can't really be sure. I've programmed a lot of batch and I've never seen that happen before. I don't think it's necessary to change all .bat comments from rem to :: to address this issue. That note is stale anyway since we no longer set the errorlevel.

@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.