Compile failure in hostip.c without USE_CURL_ASYNC #6831
Labels
Comments
jay
added a commit
to jay/curl
that referenced
this issue
Apr 1, 2021
- Define Curl_resolver_error function only when USE_CURL_ASYNC. Prior to this change building curl without an asynchronous resolver backend (c-ares or threaded) and without DoH (DNS-over-HTTPS, also asynchronous but independent of resolver backend) would cause a build error since Curl_resolver_error is called by and evaluates variables only available in asynchronous builds. Reported-by: Benbuck Nason Fixes curl#6831 Closes #xxxx
jay
added a commit
to jay/curl
that referenced
this issue
Apr 1, 2021
- Define Curl_resolver_error function only when USE_CURL_ASYNC. Prior to this change building curl without an asynchronous resolver backend (c-ares or threaded) and without DoH (DNS-over-HTTPS, also asynchronous but independent of resolver backend) would cause a build error since Curl_resolver_error is called by and evaluates variables only available in asynchronous builds. Reported-by: Benbuck Nason Fixes curl#6831 Closes #xxxx
|
I can reproduce this but only if the DNS backend is synchronous and DOH is disabled. See #6832 |
|
Hi @jay, I appreciate the quick response, and yes, our configuration is probably pretty unusual. I think maybe it would be good to add the same ifdef to Curl_resolver_error() in hostip.h for consistency? Thanks, |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
When building the latest curl (7.76.0) without asynchronous name resolution (
USE_CURL_ASYNCis undefined), hostip.c fails to compile because thefailf()call references theasyncmember which doesn't exist. Probably this whole function can be omitted in this scenario.Thanks,
Benbuck
The text was updated successfully, but these errors were encountered: