-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curl 7.76.0 segfault during connection close (SFTP + HTTPPROXYTUNNEL + HTTPS proxy) #6898
Comments
So how is the connection NULL? It gets a connection attached to the transfer in |
I spent a little time looking at a core, and here is what I have found:
The outer transfer in FWIW I am guessing 215db086e09665ee7af9b646ad6c4d6e281001ac is the source of the regression . It introduced a detaching of a connection during |
It seems totally reasonable to suspect that commit for having caused this regression. Unfortunately, that was a refactor that can't be reversed easily so the fix for this issue cannot be as easy as to revert that commit. This use case is a bit complicated and we clearly don't test this setup properly - as then we would've caught this in the CI before we merged this change. I don't know when I'll get time to look at this any closer. |
The libssh2 backend has SSH session associated with the connection but the callback context is the easy handle, so when a connection gets attached to a transfer, the protocol handler now allows for a custom function to get used to set things up correctly. Reported-by: Michael O'Farrell Fixes #6898
Is this the related to the report here? https://gitlab.alpinelinux.org/alpine/aports/-/issues/12733 |
Hardly, this issue involved SFTP - and is already fixed. |
No worries, proves that I was searching before posting a new issue though ha ha |
I did this
Curl segfaults during shutdown with a null connection:
https://github.com/curl/curl/blob/master/lib/vssh/libssh2.c#L3030
Stacktrace:
I expected the following
Curl to not crash during shutdown
curl/libcurl version
Known working in:
operating system
CentOS 8
The text was updated successfully, but these errors were encountered: