Rustls compilation should include CoreFoundation and Security frameworks on Mac #6955
Comments
kevinburke
added a commit
to kevinburke/curl
that referenced
this issue
Apr 24, 2021
Previously compiling rustls on Mac would only complete if you also compiled the SecureTransport TLS backend, which curl would prefer to the Rust backend. Appending these flags to LDFLAGS makes it possible to compile the Rustls backend on Mac without the SecureTransport backend, which means this patch will make it possible for Mac users to use the Rustls backend for TLS. Fixes curl#6955.
|
@jsha, thoughts? |
|
I think this is correct, and sent an approval on the corresponding PR (#6956) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Without these frameworks compiled in, the
--with-rustlsflag on Macs fails with a bunch of errors related to missing symbols that are present in the CoreFoundation or Security frameworks.People may not notice this because compilation does not error if you include the
--with-secure-transportflag - that one appends the correct CoreFoundation framework flags to LDFLAGS. Unfortunately including that flag means that curl chooses SecureTransport for TLS and not rustls, so as is, it's essentially impossible to use rustls for TLS on Mac.The text was updated successfully, but these errors were encountered: