Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conncache using case-sensitive hash leads to missed reuse opportunities #7159

Closed
piru opened this issue May 31, 2021 · 0 comments
Closed

Conncache using case-sensitive hash leads to missed reuse opportunities #7159

piru opened this issue May 31, 2021 · 0 comments
Labels
connecting & proxies performance

Comments

@piru
Copy link

piru commented May 31, 2021

I did this

curl -v https://example.com https://Example.com

I expected the following

Connection being reused instead of new connection being created for the 2nd request.

curl/libcurl version

curl 7.77.1-DEV (x86_64-pc-linux-gnu) libcurl/7.77.1-DEV OpenSSL/1.1.1k zlib/1.2.11 brotli/1.0.9 libidn2/2.3.0 libpsl/0.21.0 (+libidn2/2.3.0) nghttp2/1.43.0 librtmp/2.3 OpenLDAP/2.4.57 libmetalink/0.1.3
Release-Date: [unreleased]
Protocols: dict file ftp ftps gopher gophers http https imap imaps ldap ldaps mqtt pop3 pop3s rtmp rtsp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS brotli HSTS HTTP2 HTTPS-proxy IDN IPv6 Largefile libz Metalink NTLM NTLM_WB PSL SSL TLS-SRP UnixSockets

operating system

Linux anonymized 5.10.0-6-amd64 #1 SMP Debian 5.10.28-1 (2021-04-09) x86_64 GNU/Linux
bagder added a commit that referenced this issue Jun 1, 2021
@bagder
conncache: lowercase the hash key for better match
241310e 
As host names are case insensitive, the use of case sensitive hashing
caused unnecesary cache misses and therefore lost performance. This
lowercases the hash key.

Reported-by: Harry Sintonen
Fixes #7159
@bagder bagder mentioned this issue Jun 1, 2021
Closed
@bagder bagder closed this as completed in dddad33 Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
connecting & proxies performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

conncache: lowercase the hash key for better match curl/curl
2 participants
@bagder @piru