Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: inconsistent configure option "get-easy-option" #7211

Closed
Bastian-Krause opened this issue Jun 8, 2021 · 1 comment
Closed

configure: inconsistent configure option "get-easy-option" #7211

Bastian-Krause opened this issue Jun 8, 2021 · 1 comment
Labels
build

Comments

@Bastian-Krause
Copy link
Contributor

@Bastian-Krause Bastian-Krause commented Jun 8, 2021

Hi,

the help text and the configure option get-easy-option/get-easy-options are inconsistent:

curl/configure.ac

Lines 3803 to 3809 in a3a298d

dnl ************************************************************
dnl disable the curl_easy_options API
dnl
AC_MSG_CHECKING([whether to support curl_easy_option*])
AC_ARG_ENABLE(get-easy-option,
AS_HELP_STRING([--enable-get-easy-options],[Enable curl_easy_options])
AS_HELP_STRING([--disable-get-easy-options],[Disable curl_easy_options]),

I am not sure which variant is correct here, so I'm opening this issue instead of a PR.
@bagder bagder added the build label Jun 8, 2021
@bagder
Copy link
Member

@bagder bagder commented Jun 8, 2021

Since this sets the define CURL_DISABLE_GETOPTIONS with a plural s, maybe go with that for all of them?

Bastian-Krause added a commit to Bastian-Krause/curl that referenced this issue Jun 8, 2021
@Bastian-Krause
configure: rename get-easy-option configure option to get-easy-options
b1d2f31 
"get-easy-options" is the configure option advertised by the help text
anyway, so use that.

Closes curl#7211

Fixes: ad691b1 ("configure: added --disable-get-easy-options")
Suggested-by: Daniel Stenberg <daniel@haxx.se>
Signed-off-by: Bastian Krause <bst@pengutronix.de>
@Bastian-Krause Bastian-Krause mentioned this issue Jun 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

configure: rename get-easy-option configure option to get-easy-options Bastian-Krause/curl
2 participants
@bagder @Bastian-Krause