Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure shouldn't silently strip debug options #7216

Closed
Hello71 opened this issue Jun 8, 2021 · 2 comments
Closed

configure shouldn't silently strip debug options #7216

Hello71 opened this issue Jun 8, 2021 · 2 comments
Labels

Comments

@Hello71
Copy link
Contributor

@Hello71 Hello71 commented Jun 8, 2021

CFLAGS=-g ./configure assumes --without-debug then ignores -g. i think that without explicit --without-debug it shouldn't be ignored at all, and even with --without-debug it should allow compiling with -g anyways (interpreting --without-debug as "don't add debug flags", not "remove all debugging functionality") or at least issue an error and fail loudly.

CURL_VAR_STRIP([tmp_CFLAGS],[$flags_dbg_all])

i suspect this was initially done due to autoconf CFLAGS="-g -O2" default, but it's a very unintuitive behavior, and from a distro level means we need to do special work to support curl debugging. --with-debug seems not right for us either, since we may want to specify our own setting. in fact, as i read it, it is currently totally impossible to set anything other than -g (with gcc/clang), since -g* is stripped and replaced with either -g or nothing.

@jay jay added the build label Jun 9, 2021
bagder added a commit that referenced this issue Jun 16, 2021
To allow users to set them when invoking configure without using
--with-debug.

Reported-by: Alex Xu
Fixes #7216
@bagder
Copy link
Member

@bagder bagder commented Jun 17, 2021

@Hello71 I presume #7267 is then in line with your thinking?

@Hello71
Copy link
Contributor Author

@Hello71 Hello71 commented Jun 17, 2021

yes, thanks!

@bagder bagder closed this in 6dd35dd Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants