Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinBuild : Documentation does not include VC 16 #7253

Closed
HughMacdonald opened this issue Jun 14, 2021 · 2 comments
Closed

WinBuild : Documentation does not include VC 16 #7253

HughMacdonald opened this issue Jun 14, 2021 · 2 comments

Comments

@HughMacdonald
Copy link

@HughMacdonald HughMacdonald commented Jun 14, 2021

This is a tiny thing, and apologies if I've misunderstood anything.

I'm running Visual Studio 16.10.0 here, which I'm guessing is the same version as VC. In the winbuild/README.md, the options for the -VC flag include up to 15, but should probably include 16 too. Running it with -VC=16 worked fine for me.

@bagder
Copy link
Member

@bagder bagder commented Jun 14, 2021

It probably should, yes. Or be rephrased to work generically since the only check that's currently done with that variable is if it is version 6, all others are treated the same...

bagder added a commit that referenced this issue Jun 14, 2021
Previously it listed all versions up to 15 (missing 16) but this new
phrasing is more open ended.

Fixes #7253
Reported-by: Hugh Macdonald
@HughMacdonald
Copy link
Author

@HughMacdonald HughMacdonald commented Jun 14, 2021

Cool stuff - thanks! It only threw me for a second, and it seemed to build just fine.

@bagder bagder closed this in ce8a38f Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants