Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP2 is disabled when the static libnghttp2 is used #7367

Closed
t-artikov opened this issue Jul 8, 2021 · 1 comment
Closed

HTTP2 is disabled when the static libnghttp2 is used #7367

t-artikov opened this issue Jul 8, 2021 · 1 comment

Comments

@t-artikov
Copy link

@t-artikov t-artikov commented Jul 8, 2021

I did this

Build libcurl/7.77.0 using conan with the "libcurl:with_nghttp2=True" option.
The configure run is:

./configure --with-libidn2=no --with-librtmp=no --with-libmetalink=no --with-libpsl=no --with-schannel=no --with-secure-transport=no --with-brotli=no --enable-shared=no --enable-static=yes --enable-ldap=no --enable-debug=no --enable-ares=no --enable-threaded-resolver=no --with-ssl=/home/timur/.conan/data/openssl/1.1.1k/_/_/package/6af9cc7cb931c5ad942174fd7838eb655717c709 --without-wolfssl --without-libssh2 --with-nghttp2=/home/timur/.conan/data/libnghttp2/1.43.0/_/_/package/73a74e193755279f0ff229bc764a55e96c74fcbe --with-zlib=/home/timur/.conan/data/zlib/1.2.11/_/_/package/6af9cc7cb931c5ad942174fd7838eb655717c709 --with-zstd=no --prefix=/home/timur/.conan/data/libcurl/7.77.0/_/_/package/ba5e49f4e2d043d6133c1446fb84c2cc40d018f7 --bindir=${prefix}/bin --sbindir=${prefix}/bin --libexecdir=${prefix}/bin --libdir=${prefix}/lib --includedir=${prefix}/include --oldincludedir=${prefix}/include --datarootdir=${prefix}/share

I expected the following

The library with HTTP2 is compiled.

Actual result

HTTP2 is disabled in the resulting library.
See the config.log. There is

configure:30785: checking for nghttp2_session_set_local_window_size in -lnghttp2
...
/usr/bin/ld: cannot find -lnghttp2

error, because the actual library name is libnghttp2_static.a.
I believe I know how to fix it, and will make a PR soon.

curl/libcurl version

curl 7.77.0 (x86_64-pc-linux-gnu) libcurl/7.77.0 OpenSSL/1.1.1k zlib/1.2.11
Release-Date: 2021-05-26
Protocols: dict file ftp ftps gopher gophers http https imap imaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: alt-svc HSTS HTTPS-proxy IPv6 Largefile libz NTLM NTLM_WB SSL TLS-SRP UnixSockets

operating system

Linux timur-pc 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

t-artikov pushed a commit to t-artikov/curl that referenced this issue Jul 8, 2021
Don't hardcode the nghttp2 library name,
because it can vary, be "nghttp2_static" for example.

Closes curl#7367
@t-artikov
Copy link
Author

@t-artikov t-artikov commented Jul 8, 2021

PR: #7368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants