Skip to content

/ curl Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: disable HSTS support #7669

Closed
MAntoniak opened this issue Sep 3, 2021 · 1 comment
Closed

configure: disable HSTS support #7669

MAntoniak opened this issue Sep 3, 2021 · 1 comment
Labels
build

Comments

@MAntoniak
Copy link
Contributor

@MAntoniak MAntoniak commented Sep 3, 2021

I download a curl library from daily snapshots. I am trying to set up a build with openssl but no hsts support.
Looks like the use of:

./configure
./configure --disable-hsts
./configure --enable-hsts=no

gives the same result:

   curl version: 7.79.0-20210903
...
   HSTS: enabled (--disable-hsts)

I'm not sure if this is correct behavior? What am I missing?
@bagder bagder added the build label Sep 3, 2021
@bagder
Copy link
Member

@bagder bagder commented Sep 3, 2021

I can reproduce, but I haven't yet figured out why it does this...

bagder added a commit that referenced this issue Sep 4, 2021
@bagder
configure: make --disable-hsts work
Verified
This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about vigilant mode.
Loading status checks…
6f753b8 
The AC_ARG_ENABLE() macro itself uses a variable called
'enable_[option]', so when our script also used a variable with that
name for the purpose of storing what the user wants, it also
accidentally made it impossible to switch off the feature with
--disable-hsts. Fix this by renaming our variable.

Reported-by: Michał Antoniak
Fixes #7669
Closes #
@bagder bagder mentioned this issue Sep 4, 2021
Closed
@bagder bagder closed this in 9829b94 Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

configure: make --disable-hsts work
2 participants
@bagder @MAntoniak