Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure reports error detecting OpenSSL 3 headers #7758

Closed
rsbeckerca opened this issue Sep 22, 2021 · 5 comments
Closed

Configure reports error detecting OpenSSL 3 headers #7758

rsbeckerca opened this issue Sep 22, 2021 · 5 comments
Labels
build

Comments

@rsbeckerca
Copy link
Contributor

When configure runs, the following is reported:

checking for OpenSSL headers version... sed: -e expression #1, char 0: no previous regular expression
unknown - 0x

I cannot find this error in config.log - stderr is not captured for this sed instance. This does not actually impact the final result.

I did this

CPPFLAGS="-D_XOPEN_SOURCE_EXTENDED=1 -WIEEE_float -I/usr/local-ssl3.0_32/openssl/include" LDFLAGS="-L/usr/local-ssl3.0_32/lib" ./configure --prefix=/usr/local-ssl3.0 --with-ssl=/usr/local-ssl3.0_32 --with-ca-path=/usr/local-ssl3.0/ssl/certs --disable-pthreads --disable-threaded-resolver --enable-ipv6

I expected the following

The OpenSSL version in the header displayed, but I understand that it is more complex than in version 1.

curl/libcurl version

curl 7.79.1 (nsx-tandem-nsk) libcurl/7.79.1 OpenSSL/3.0.0 zlib/1.2.8
Release-Date: 2021-09-22
Protocols: dict file ftp ftps gopher gophers http https imap imaps mqtt pop3 pop3s rtsp smtp smtps telnet tftp
Features: alt-svc HSTS HTTPS-proxy IPv6 libz NTLM NTLM_WB SSL TLS-SRP UnixSockets

operating system

NONSTOP_KERNEL mysys L20 10 NSX-D NSX NSX-D NonStop Kernel
@bagder bagder added the build label Sep 22, 2021
@bagder
Copy link
Member

bagder commented Sep 22, 2021

I would presume it is the sed line added in commit f09030b but that works on all the systems I've seen it run on so I can't really tell why it causes a problem for you.

@rsbeckerca
Copy link
Contributor Author

rsbeckerca commented Sep 22, 2021 •
edited

I would presume it is the sed line added in commit f09030b but that works on all the systems I've seen it run on so I can't really tell why it causes a problem for you.

I have tried the sed command from that commit, with no trouble. The issue is that the command is being executed inside a sub-shell, so ksh needs a double escape for ", as in \\". Instead of sed s/\"//g, could you use a more stable sed 's/"//g' instead? I can provide the simple Pull Request, if desired.

bagder added a commit that referenced this issue Sep 23, 2021
@bagder
curl-openssl: pass argument to sed single-quoted
dca842d 
... instead of using an escaped double-quote. This is an attempt to make
this work better with ksh that otherwise would insist on a double
escape!

Reported-by: Randall S. Becker
Fixes #7758
@bagder bagder mentioned this issue Sep 23, 2021
Closed
@bagder
Copy link
Member

bagder commented Sep 23, 2021

See #7764

@rsbeckerca
Copy link
Contributor Author

See #7764

I applied the change and manually to configure:

checking for OpenSSL headers version... 3.0.0 - 0x300

That looks good. Thanks.

@bagder
Copy link
Member

bagder commented Sep 23, 2021

excellent!

@bagder bagder closed this as completed in 7aaf533 Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

curl-openssl: pass argument to sed single-quoted curl/curl
2 participants
@bagder @rsbeckerca