Compiling with Clang on Windows fails at libcurl.rc

[VitalyVaryvdin]

I did this

Compiling on Windows 10 with Clang 12.0.1. Ninja build files generated by CMake.
Getting error at curl/lib/libcurl.rc.
llvm-rc: error in versioninfo statement (id 1): [build] non-ascii 8-bit codepoint (169) can't occur in a non-unicode string

Removing everything coming after #define RC_VERSION results in successful compilation.

I expected the following

Successful compilation

curl/libcurl version

7.79.1-DEV

operating system

Windows 10.

UPD:
The issue is here VALUE "LegalCopyright", "\xa9 " LIBCURL_COPYRIGHT "\0" /* a9: Copyright symbol */. Removing this results in successful compilation.
To be exact it doesn't like "\xa9 " part.

UPD:
Adding L before the string fixes the issue.
VALUE "LegalCopyright", "\xa9 " LIBCURL_COPYRIGHT "\0" /* a9: Copyright symbol */
Becomes
VALUE "LegalCopyright", L"\xa9 " LIBCURL_COPYRIGHT "\0" /* a9: Copyright symbol */

Copyright symbol is properly displayed in .dll info

Tested under Clang 12.0.1 and MSVC 16.9

[bagder]

Is this perhaps what's needed? It seems it assumes a certain dir tree layout that may not be true

--- a/lib/libcurl.rc
+++ b/lib/libcurl.rc
@@ -18,11 +18,11 @@
  * This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
  * KIND, either express or implied.
  *
  ***************************************************************************/
 #include <winver.h>
-#include "../include/curl/curlver.h"
+#include <curl/curlver.h>
 
 LANGUAGE  0, 0
 
 #define RC_VERSION  LIBCURL_VERSION_MAJOR, LIBCURL_VERSION_MINOR, LIBCURL_VERSION_PATCH, 0
 

[VitalyVaryvdin]

Nope, doesn't fix the issue.

The issue is here VALUE "LegalCopyright", "\xa9 " LIBCURL_COPYRIGHT "\0" /* a9: Copyright symbol */. Removing this results in successful compilation.

To be exact it doesn't like "\xa9 " part.

[bagder]

Ok, that's beyond me. @vszakats, any idea?

[VitalyVaryvdin]

Not sure if that's correct way to fix that but adding L before the string fixes the issue.

VALUE "LegalCopyright", "\xa9 " LIBCURL_COPYRIGHT "\0" /* a9: Copyright symbol */
Becomes
VALUE "LegalCopyright", L"\xa9 " LIBCURL_COPYRIGHT "\0" /* a9: Copyright symbol */

Copyright symbol is properly displayed in .dll info

Upd: works under MSVC 16.9 as well

[vszakats]

Codepage requirements/expectations of various compilers and of Windows resource files in general are generally mysterious, so what about replacing that copyright symbol with: (c)? /cc @bagder

Prefixing with L looks interesting, though I have no clue why it works and how portable that is.

UPDATE: L also fixes it in my (non-Windows) LLVM/clang 12.0.1 + mingw-w64 env with command: x86_64-w64-mingw32-windres -c65001. Another thing to try is a literal © and/or the -c65001 (or /C 65001) option.

[VitalyVaryvdin]

According to https://docs.microsoft.com/en-us/windows/win32/menurc/stringtable-resource

To encode Unicode characters, use an "L" followed by the Unicode characters enclosed by quotes. See the Examples section for an example.

IDS_RUSSIANSTRING L"\x0421\x043f\x0440\x0430\x0432\x043a\x0430"

I might assume this being pretty portable and common practice.

[vszakats]

@VitalyVaryvdin Thanks for the link! It looks good to me. This method may even make any -c codepage options unnecessary.

[bagder]

I personally wouldn't mind using the ascii (C) version either. Whatever makes this work better.

[VitalyVaryvdin]

You're welcome!

Using (C) would probably be better option, since it presumable would never bring any issues.