Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test 1451 currently failing on FreeBSD #7924

Closed
mback2k opened this issue Oct 29, 2021 · 1 comment
Closed

Test 1451 currently failing on FreeBSD #7924

mback2k opened this issue Oct 29, 2021 · 1 comment
Assignees
@mback2k
Labels
CI tests

Comments

@mback2k
Copy link
Member

@mback2k mback2k commented Oct 29, 2021

I did this

Checked recent failures of FreeBSD CI runs on Cirrus CI and found these:
https://cirrus-ci.com/task/5915266958753792?logs=test#L2305
https://cirrus-ci.com/task/4789367051911168?logs=test#L2305

I expected the following

Test to work just like on other platforms.
@mback2k mback2k added tests CI labels Oct 29, 2021
@mback2k
Copy link
Member Author

@mback2k mback2k commented Oct 29, 2021

This may be related due to the change of smbserver.py using Python 3 instead of Python 2, will have to investigate more.

@mback2k mback2k self-assigned this Oct 31, 2021
mback2k added a commit to mback2k/curl that referenced this issue Nov 1, 2021
@mback2k
tests/smbserver.py: fix compatibility with impacket 0.9.23+
bdbbd1a 
impacket now performs sanity checks if the requested and to
be served file path actually is inside the real share path.

Ref: SecureAuthCorp/impacket#1066

Fixes curl#7924
@mback2k mback2k mentioned this issue Nov 1, 2021
Closed
mback2k added a commit to mback2k/curl that referenced this issue Nov 1, 2021
@mback2k
tests/smbserver.py: fix compatibility with impacket 0.9.23+
6eea6a7 
impacket now performs sanity checks if the requested and to
be served file path actually is inside the real share path.

Ref: SecureAuthCorp/impacket#1066

Fixes curl#7924
@mback2k mback2k closed this as completed in d52316e Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mback2k mback2k

Labels
CI tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests/smbserver.py: fix compatibility with impacket 0.9.23+ mback2k/curl
1 participant
@mback2k