-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible improper locking issues #7926
Labels
Comments
It does indeed look very wrong. You up for writing a pull request and fix it? |
Sorry, I don't know which is the best way to fix them due to being unaware of the shared data protected by the lock. But, here is my try. Is this enough to fix this issue?
|
bagder
added a commit
that referenced
this issue
Oct 31, 2021
Reported-by: ryancaicse on github Fixes #7926
I think it needs more than that. See #7931 for my proposed fix. |
OK, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
HI, in this function, it is possible that the lock
lock
(Line 71) is not released properly because the execution does not enter thewhile(j < num_urls)
? Also, it also seems that the locklock
could be released multiple times in the while loop at Line 97.Thanks for checking.
curl/docs/examples/smooth-gtk-thread.c
Lines 68 to 113 in 3085ccf
The text was updated successfully, but these errors were encountered: