Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The quiche+boring CI builds fail on Zuul #7927

Closed
bagder opened this issue Oct 30, 2021 · 2 comments
Closed

The quiche+boring CI builds fail on Zuul #7927

bagder opened this issue Oct 30, 2021 · 2 comments

Comments

@bagder
Copy link
Member

@bagder bagder commented Oct 30, 2021

I did this

I checked recent CI builds. I noticed that both builds on zuul that build quiche (+boringssl) fail consistently. The build ends with:

  -- Build files have been written to: /home/zuul/quiche/target/release/build/quiche-986e736b297204f2/out/build
  running: "cmake" "--build" "." "--target" "bssl" "--config" "RelWithDebInfo" "--parallel" "8"

  --- stderr
  Unknown argument --parallel
  Unknown argument 8
  Usage: cmake --build <dir> [options] [-- [native-options]]
  Options:
    <dir>          = Project binary directory to be built.
    --target <tgt> = Build <tgt> instead of default targets.
                     May only be specified once.
    --config <cfg> = For multi-configuration tools, choose <cfg>.
    --clean-first  = Build target 'clean' first, then build.
                     (To clean only, use --target 'clean'.)
    --use-stderr   = Ignored.  Behavior is default in CMake >= 3.0.
    --             = Pass remaining options to the native tool.
  thread 'main' panicked at '
  command did not execute successfully, got: exit status: 1

example failure

I think this is the boringssl part? It looks like it uses a cmake option that the cmake version used here doesn't support.

I expected the following

All quiche builds to be fine.

curl/libcurl version

current git master

operating system

These builds run on ubuntu-bionic.

@bagder bagder added the CI label Oct 30, 2021
@bagder
Copy link
Member Author

@bagder bagder commented Oct 30, 2021

@ghedo can you make sense of this? Is this the boringssl build from within quiche and if so, do you know if we can make it not use the --parallel option?

Loading

@bagder
Copy link
Member Author

@bagder bagder commented Nov 3, 2021

Ubuntu bionic ships with cmake 3.10

The cmake --parallel command line option was introduced in cmake 3.12.

... yet the boringssl CMakeLists.txt file says:

cmake_minimum_required(VERSION 3.5)

Loading

@bagder bagder added the HTTP/3 label Nov 3, 2021
bagder added a commit that referenced this issue Nov 3, 2021
... in an attempt to avoid BoringSSL using cmake --parallel because
that's an option that doesn't exist in the cmake shipped in Ubuntu
Bionic, which is a system commonly used in our CI systems.

Fixes #7927
@bagder bagder closed this in 2f5049a Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant