Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl CMake script uses identifiers reserved by CMake. #7988

Closed
Boris-Rasin opened this issue Nov 10, 2021 · 1 comment
Closed

Curl CMake script uses identifiers reserved by CMake. #7988

Boris-Rasin opened this issue Nov 10, 2021 · 1 comment

Comments

@Boris-Rasin
Copy link
Contributor

@Boris-Rasin Boris-Rasin commented Nov 10, 2021

From here: https://cmake.org/cmake/help/latest/manual/cmake-variables.7.html

CMake reserves identifiers that:
    begin with CMAKE_ (upper-, lower-, or mixed-case)

Following identifiers are declared by curl CMake script (there may be more):

CMAKE_USE_SCHANNEL
CMAKE_USE_SECTRANSP
CMAKE_USE_OPENSSL
CMAKE_USE_MBEDTLS
CMAKE_USE_BEARSSL
CMAKE_USE_NSS
CMAKE_USE_WOLFSSL

I suggest changing these identifiers to use CURL_ prefix instead:

CURL_USE_SCHANNEL
CURL_USE_SECTRANSP
CURL_USE_OPENSSL
CURL_USE_MBEDTLS
CURL_USE_BEARSSL
CURL_USE_NSS
CURL_USE_WOLFSSL

curl/libcurl version

7.80.0

@jzakrzewski
Copy link
Contributor

@jzakrzewski jzakrzewski commented Nov 15, 2021

I'm all in for the change. Just note that it'll break scripts (if any) that build curl using CMake.

bagder added a commit that referenced this issue Nov 22, 2021
Since the 'CMAKE_' prefix is reserved for cmake's own private use.
Ref: https://cmake.org/cmake/help/latest/manual/cmake-variables.7.html

Reported-by: Boris Rasin
Fixes #7988
@bagder bagder closed this in 9108da2 Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants