Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: detect an incorrectly-built Hyper #8001

Closed
jsha opened this issue Nov 13, 2021 · 0 comments
Closed

configure: detect an incorrectly-built Hyper #8001

jsha opened this issue Nov 13, 2021 · 0 comments
Assignees
@bagder
Labels
build enhancement Hyper

Comments

@jsha
Copy link
Contributor

jsha commented Nov 13, 2021

I did this

In Hyper directory:

cargo build

In curl directory:

./configure --with-hyper=$HOME/rust/hyper/

I expected the following

Success!

I got the following

configure: error: --with-hyper but hyper was not found. See docs/HYPER.md.

The problem is that I didn't build Hyper with the appropriate feature flags. The message is confusing because Hyper did exist and was in the right place, but didn't have the correct symbols. We should add a check to configure that the file (libhyper.a) exists in the given directory. If the file exists but the build fails, we can specifically say "hyper was found but it was built with the wrong flags. See docs/HYPER.md"

/cc @kevinburke
bagder added a commit that referenced this issue Nov 13, 2021
@bagder
configure: better diagnostics if hyper is built wrong
321146d 
If hyper is indeed present in the specified directory but couldn't be
used to find the correct symbol, then offer a different error message to
better help the user understand the issue.

Sugggested-by: Jacob Hoffman-Andrews
Fixes #8001
@bagder bagder mentioned this issue Nov 13, 2021
Closed
@bagder bagder self-assigned this Nov 13, 2021
@bagder bagder closed this as completed in 9492d33 Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
build enhancement Hyper
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

configure: better diagnostics if hyper is built wrong curl/curl
2 participants
@bagder @jsha