Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port zero no longer accepted in URLs #8090

Closed
bagder opened this issue Dec 3, 2021 · 0 comments
Closed

Port zero no longer accepted in URLs #8090

bagder opened this issue Dec 3, 2021 · 0 comments
Assignees
@bagder
Labels
regression URL

Comments

@bagder
Copy link
Member

bagder commented Dec 3, 2021

I did this

curl http://localhost:0
curl: (3) URL using bad/illegal format or missing URL

(via @bradfitz at https://twitter.com/bradfitz/status/1466474708841512960)

I expected the following

$ curl http://localhost:0
curl: (7) Failed to connect to localhost port 0 after 0 ms: Connection refused

This worked before 7.62.0. I even blogged about using port zero a while ago.

curl/libcurl version

7.80.0 and current git

operating system

independent
@bagder bagder self-assigned this Dec 3, 2021
bagder added a commit that referenced this issue Dec 3, 2021
@bagder
urlapi: accept port number zero
f9b226b 
This is a regression since 7.62.0 (fb30ac5).

Updated test 1560 accordingly

Reported-by: Brad Fitzpatrick
Fixes #8090
@bagder bagder mentioned this issue Dec 3, 2021
Closed
@bagder bagder closed this as completed in 92d1aee Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
regression URL
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

urlapi: accept port number zero curl/curl
1 participant
@bagder