New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl_share_setopt.3 misses availability information #826

Closed
m6w6 opened this Issue May 24, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@m6w6
Contributor

m6w6 commented May 24, 2016

E.g. when did libcurl really support CURL_LOCK_DATA_SSL_SESSION?

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay May 24, 2016

Member

It was implemented starting in 7.23.0 which was released about 4 1/2 years ago. The others symbols are many years older. I think the issue is how far back do we want to go in the newer manuals. I could add something to that one though, how about:

diff --git a/docs/libcurl/curl_share_setopt.3 b/docs/libcurl/curl_share_setopt.3
index cbdbdc5..7242b0d 100644
--- a/docs/libcurl/curl_share_setopt.3
+++ b/docs/libcurl/curl_share_setopt.3
@@ -68,7 +68,7 @@ be used!
 SSL session IDs will be shared across the easy handles using this shared
 object. This will reduce the time spent in the SSL handshake when reconnecting
 to the same server. Note SSL session IDs are reused within the same easy handle
-by default.
+by default. Added in 7.23.0.
 .RE
 .IP CURLSHOPT_UNSHARE
 This option does the opposite of \fICURLSHOPT_SHARE\fP. It specifies that
Member

jay commented May 24, 2016

It was implemented starting in 7.23.0 which was released about 4 1/2 years ago. The others symbols are many years older. I think the issue is how far back do we want to go in the newer manuals. I could add something to that one though, how about:

diff --git a/docs/libcurl/curl_share_setopt.3 b/docs/libcurl/curl_share_setopt.3
index cbdbdc5..7242b0d 100644
--- a/docs/libcurl/curl_share_setopt.3
+++ b/docs/libcurl/curl_share_setopt.3
@@ -68,7 +68,7 @@ be used!
 SSL session IDs will be shared across the easy handles using this shared
 object. This will reduce the time spent in the SSL handshake when reconnecting
 to the same server. Note SSL session IDs are reused within the same easy handle
-by default.
+by default. Added in 7.23.0.
 .RE
 .IP CURLSHOPT_UNSHARE
 This option does the opposite of \fICURLSHOPT_SHARE\fP. It specifies that

@jay jay added the documentation label May 24, 2016

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder May 24, 2016

Member

I say commit that, as it at least answers @m6w6's question.

Member

bagder commented May 24, 2016

I say commit that, as it at least answers @m6w6's question.

@m6w6

This comment has been minimized.

Show comment
Hide comment
@m6w6

m6w6 May 25, 2016

Contributor

Yeah, found it in the changelog. Usually I use the excellent symbol-in-version doc, but that didn't help, because the symbol existed way before the implementation ;)

You know there are these RHELs, CentOSes, LTSes and oldstables out there, which ship pretty old software and are even used for CI and production environments ;)

Thanks a lot!

Contributor

m6w6 commented May 25, 2016

Yeah, found it in the changelog. Usually I use the excellent symbol-in-version doc, but that didn't help, because the symbol existed way before the implementation ;)

You know there are these RHELs, CentOSes, LTSes and oldstables out there, which ship pretty old software and are even used for CI and production environments ;)

Thanks a lot!

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay May 26, 2016

Member

That's a good point Michael. @bagder would it be more appropriate then to say "Although this symbol was added in 7.10.3 it was not implemented until 7.23.0" or just keep it simple as "Added in 7.23.0"?

Member

jay commented May 26, 2016

That's a good point Michael. @bagder would it be more appropriate then to say "Although this symbol was added in 7.10.3 it was not implemented until 7.23.0" or just keep it simple as "Added in 7.23.0"?

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder May 27, 2016

Member

As this would've helped @m6w6 we can assume it might help someone else too, so I think a little more info there is better than a little less. I think.

Member

bagder commented May 27, 2016

As this would've helped @m6w6 we can assume it might help someone else too, so I think a little more info there is better than a little less. I think.

jay added a commit that referenced this issue May 29, 2016

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay May 29, 2016

Member

Thanks, landed in 694c2dc.

Member

jay commented May 29, 2016

Thanks, landed in 694c2dc.

@jay jay closed this May 29, 2016

@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.