curl_share_setopt.3 misses availability information

[m6w6]

E.g. when did libcurl really support CURL_LOCK_DATA_SSL_SESSION?

[jay]

It was implemented starting in 7.23.0 which was released about 4 1/2 years ago. The others symbols are many years older. I think the issue is how far back do we want to go in the newer manuals. I could add something to that one though, how about:

diff --git a/docs/libcurl/curl_share_setopt.3 b/docs/libcurl/curl_share_setopt.3
index cbdbdc5..7242b0d 100644
--- a/docs/libcurl/curl_share_setopt.3
+++ b/docs/libcurl/curl_share_setopt.3
@@ -68,7 +68,7 @@ be used!
 SSL session IDs will be shared across the easy handles using this shared
 object. This will reduce the time spent in the SSL handshake when reconnecting
 to the same server. Note SSL session IDs are reused within the same easy handle
-by default.
+by default. Added in 7.23.0.
 .RE
 .IP CURLSHOPT_UNSHARE
 This option does the opposite of \fICURLSHOPT_SHARE\fP. It specifies that

[jay]

It was implemented starting in 7.23.0 which was released about 4 1/2 years ago. The others symbols are many years older. I think the issue is how far back do we want to go in the newer manuals. I could add something to that one though, how about:

diff --git a/docs/libcurl/curl_share_setopt.3 b/docs/libcurl/curl_share_setopt.3
index cbdbdc5..7242b0d 100644
--- a/docs/libcurl/curl_share_setopt.3
+++ b/docs/libcurl/curl_share_setopt.3
@@ -68,7 +68,7 @@ be used!
 SSL session IDs will be shared across the easy handles using this shared
 object. This will reduce the time spent in the SSL handshake when reconnecting
 to the same server. Note SSL session IDs are reused within the same easy handle
-by default.
+by default. Added in 7.23.0.
 .RE
 .IP CURLSHOPT_UNSHARE
 This option does the opposite of \fICURLSHOPT_SHARE\fP. It specifies that

[bagder]

I say commit that, as it at least answers @m6w6's question.

[bagder]

I say commit that, as it at least answers @m6w6's question.

[m6w6]

Yeah, found it in the changelog. Usually I use the excellent symbol-in-version doc, but that didn't help, because the symbol existed way before the implementation ;)

You know there are these RHELs, CentOSes, LTSes and oldstables out there, which ship pretty old software and are even used for CI and production environments ;)

Thanks a lot!

[m6w6]

Yeah, found it in the changelog. Usually I use the excellent symbol-in-version doc, but that didn't help, because the symbol existed way before the implementation ;)

You know there are these RHELs, CentOSes, LTSes and oldstables out there, which ship pretty old software and are even used for CI and production environments ;)

Thanks a lot!

[jay]

That's a good point Michael. @bagder would it be more appropriate then to say "Although this symbol was added in 7.10.3 it was not implemented until 7.23.0" or just keep it simple as "Added in 7.23.0"?

[jay]

That's a good point Michael. @bagder would it be more appropriate then to say "Although this symbol was added in 7.10.3 it was not implemented until 7.23.0" or just keep it simple as "Added in 7.23.0"?

[bagder]

As this would've helped @m6w6 we can assume it might help someone else too, so I think a little more info there is better than a little less. I think.

[bagder]

As this would've helped @m6w6 we can assume it might help someone else too, so I think a little more info there is better than a little less. I think.

[jay]

Thanks, landed in 694c2dc.

[jay]

Thanks, landed in 694c2dc.