Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl incorrectly reports openssl header/library version mismatch during configure #8279

Closed
satmandu opened this issue Jan 14, 2022 · 5 comments
Closed

curl incorrectly reports openssl header/library version mismatch during configure #8279

satmandu opened this issue Jan 14, 2022 · 5 comments
Assignees
@bagder
Labels
build

Comments

@satmandu
Copy link
Contributor

I did this

Built curl with OpenSSL 3.0.1

I expected the following

Configure script should not warn about OpenSSL headers and library versions not matching in this case.

curl/libcurl version

[curl -V output]

/usr/local/share/musl/bin/curl -V
curl 7.81.0 (x86_64-pc-linux-musl) libcurl/7.81.0 OpenSSL/3.0.1 zlib/1.2.11 brotli/1.0.9 zstd/1.5.1 libidn2/2.3.2
Release-Date: 2022-01-05
Protocols: dict file ftp ftps gopher gophers http https mqtt pop3 pop3s smtp smtps telnet tftp
Features: alt-svc AsynchDNS brotli HSTS HTTPS-proxy IDN IPv6 Largefile libz SSL TLS-SRP UnixSockets zstd

operating system

(In a container so this isn't that relevant... Linux cheekon-x86_64 5.16.0-051600-generic #202201092355 SMP PREEMPT Mon Jan 10 00:21:11 UTC 2022 x86_64 GNU/Linux)

Relevant configure output:

checking for OpenSSL headers version... 3.0.1 - 0x301
checking for OpenSSL library version... 3.0.0
checking for OpenSSL headers and library versions matching... no
configure: WARNING: OpenSSL headers and library versions do not match.

Looks like OpenSSL will report the library version as 3.0.0 for all minor version updates of OpenSSL as per: openssl/openssl#17516
@bagder bagder added the build label Jan 14, 2022
@bagder bagder self-assigned this Jan 14, 2022
@bagder
Copy link
Member

bagder commented Jan 14, 2022

That output is totally harmless though and doesn't actually do anything.

bagder added a commit that referenced this issue Jan 14, 2022
@bagder
curl-openssl: remove the OpenSSL headers and library versions check
d5d3c8d 
It is more work to maintain that check than the (any?) benefit it
brings.

Fixes #8279
Reported-by: Satadru Pramanik
@bagder bagder mentioned this issue Jan 14, 2022
Closed
@satmandu
Copy link
Contributor Author

That output is totally harmless though and doesn't actually do anything.

So it appears, but when you're debugging building a static curl, you check every error message!

May just mention that it might be an issue, or that it might not be a problem?

Just trying to save someone some time in the future... 😅

@satmandu
Copy link
Contributor Author

I guess this is a larger upstream question: openssl/openssl#17517

@jay
Copy link
Member

jay commented Jan 14, 2022

I guess this is a larger upstream question: openssl/openssl#17517

That refers to runtime checks and the macro purposely avoids that due to cross compiling.

Ref: https://github.com/curl/curl/blob/curl-7_81_0/m4/curl-openssl.m4#L116

@bagder
Copy link
Member

bagder commented Jan 14, 2022

Yeah, that openssl issue is completely separate and independent from this configure check that I propose we simply remove (in #8280)

@bagder bagder closed this as completed in 66250c4 Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
build
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

curl-openssl: remove the OpenSSL headers and library versions check curl/curl
3 participants
@bagder @jay @satmandu